Refactor menu controller to isolate aura dependency.

ui/views/controls/menu/menu_message_loop.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.

[tapted, 2014/05/04 23:43:39]

nit: No "(c)" in headers any more

[Andre, 2014/05/05 22:41:29]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_VIEWS_CONTROLS_MENU_MENU_MESSAGE_LOOP_H_
+#define UI_VIEWS_CONTROLS_MENU_MENU_MESSAGE_LOOP_H_
+
+namespace ui {
+class LocatedEvent;
+}
+
+namespace views {
+
+class MenuController;
+
+class MenuMessageLoop {

[tapted, 2014/05/04 23:43:39]

nit: should have a class comment

[Andre, 2014/05/05 22:41:29]

Done.

+ public:
+  virtual ~MenuMessageLoop() {}
+  // Runs the platform specific bits of the message loop. If |nested_menu| is
+  // true we're being asked to run a menu from within a menu (eg a context
+  // menu).
+  virtual void Run(MenuController*, bool nested_menu);

[tapted, 2014/05/04 23:43:39]

It's more typical to declare a pure-virtual interface, and just expose a static
`Create()` method that needs to be implemented per-platform. See e.g. what's
done for ui/views/widget/native_widget_private.h

It means re-declaring a lot of stuff, but allows the platform classes to have
their own data members if they need it.

[Andre, 2014/05/05 22:41:29]

Done.

+
+  bool ShouldQuitNow() const;
+  virtual void QuitNow();
+  void RepostEvent(const ui::LocatedEvent& event);
+};

[tapted, 2014/05/04 23:43:39]

nit (unless it's just pure virtual methods):

private:
  DISALLOW_COPY_AND_ASSIGN(..)

[Andre, 2014/05/05 22:41:29]

Changed to pure virtual.

+
+}  // namespace views
+
+#endif  // UI_VIEWS_CONTROLS_MENU_MENU_MESSAGE_LOOP_H_