Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26759003: Remove HTMLMediaElement.webkitHasClosedCaptions/webkitClosedCaptionsVisible (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
CC:
blink-reviews, nessy, eae+blinkwatch, leviw+renderwatch, feature-media-reviews_chromium.org, dglazkov+blink, Inactive, jchaffraix+rendering, vcarbune.chromium, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove HTMLMediaElement.webkitHasClosedCaptions/webkitClosedCaptionsVisible See the bug for why it is (probably) best to remove these. Move some things in HTMLMediaElement.idl to match the spec order and to leave all WebKit extensions in a group at the end. Drop duplicate TreatNullAs=NullString introduced in r159260. BUG=305753 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159317

Patch Set 1 #

Patch Set 2 : rebase to resolve conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -129 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/media/track/track-in-band-legacy-api.html View 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/media/track/track-in-band-legacy-api-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
M ManualTests/media-controls.html View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderMediaControls.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
The last easy-to-remove WebKit quirk from HTMLMediaElement as far as I can see. Happy reviewing!
7 years, 2 months ago (2013-10-09 20:52:40 UTC) #1
eseidel
lgtm
7 years, 2 months ago (2013-10-09 21:03:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/26759003/1
7 years, 2 months ago (2013-10-09 21:04:08 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=8480
7 years, 2 months ago (2013-10-10 03:55:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/26759003/9001
7 years, 2 months ago (2013-10-10 07:54:22 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 08:58:52 UTC) #6
Message was sent while issue was closed. 
Change committed as 159317

Powered by Google App Engine
This is Rietveld 408576698