Fixing mismatch between expected and declared minimum values.

base/android/record_histogram.cc

Index: base/android/record_histogram.cc
diff --git a/base/android/record_histogram.cc b/base/android/record_histogram.cc
index 5679762ee07c1ecc0b604bb842d20e9323a67ec5..fe8403ee1c428de416128e316395204cbb21ee4c 100644
--- a/base/android/record_histogram.cc
+++ b/base/android/record_histogram.cc
@@ -53,12 +53,15 @@ class HistogramCache {
                           jstring j_histogram_name,
                           int32_t expected_min,
                           int32_t expected_max,
-                          int32_t expected_bucket_count,
+                          uint32_t expected_bucket_count,
                           HistogramBase* histogram) {
+    std::string histogram_name = ConvertJavaStringToUTF8(env, j_histogram_name);
+    Histogram::InspectConstructionArguments(

[Alexei Svitkine (slow), 2017/02/07 18:00:44]

Can you assign the return value to a var and DCHECK on it - same as is done in
base/metrics/ code?

e.g. from base/metrics:
  bool valid_arguments = Histogram::InspectConstructionArguments(
      name, &minimum, &maximum, &bucket_count);
  DCHECK(valid_arguments);

+        histogram_name, &expected_min, &expected_max, &expected_bucket_count);
     DCHECK(histogram->HasConstructionArguments(expected_min, expected_max,
                                                expected_bucket_count))
-        << ConvertJavaStringToUTF8(env, j_histogram_name) << "/" << expected_min
-        << "/" << expected_max << "/" << expected_bucket_count << " vs. "
+        << histogram_name << "/" << expected_min << "/" << expected_max << "/"
+        << expected_bucket_count << " vs. "
         << HistogramConstructionParamsToString(histogram);
   }