Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Issue 2675863002: DevTools: attribute long Set-Cookie warning to a target. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 20 matching lines...) Expand all
31 /** 31 /**
32 * @unrestricted 32 * @unrestricted
33 */ 33 */
34 SDK.NetworkManager = class extends SDK.SDKModel { 34 SDK.NetworkManager = class extends SDK.SDKModel {
35 /** 35 /**
36 * @param {!SDK.Target} target 36 * @param {!SDK.Target} target
37 */ 37 */
38 constructor(target) { 38 constructor(target) {
39 super(target); 39 super(target);
40 this._dispatcher = new SDK.NetworkDispatcher(this); 40 this._dispatcher = new SDK.NetworkDispatcher(this);
41 this._target = target;
42 this._networkAgent = target.networkAgent(); 41 this._networkAgent = target.networkAgent();
43 target.registerNetworkDispatcher(this._dispatcher); 42 target.registerNetworkDispatcher(this._dispatcher);
44 if (Common.moduleSetting('cacheDisabled').get()) 43 if (Common.moduleSetting('cacheDisabled').get())
45 this._networkAgent.setCacheDisabled(true); 44 this._networkAgent.setCacheDisabled(true);
46 if (Common.moduleSetting('monitoringXHREnabled').get()) 45 if (Common.moduleSetting('monitoringXHREnabled').get())
47 this._networkAgent.setMonitoringXHREnabled(true); 46 this._networkAgent.setMonitoringXHREnabled(true);
48 47
49 // Limit buffer when talking to a remote device. 48 // Limit buffer when talking to a remote device.
50 if (Runtime.queryParam('remoteFrontend') || Runtime.queryParam('ws')) 49 if (Runtime.queryParam('remoteFrontend') || Runtime.queryParam('ws'))
51 this._networkAgent.enable(10000000, 5000000); 50 this._networkAgent.enable(10000000, 5000000);
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 242
244 if (response.fromDiskCache) 243 if (response.fromDiskCache)
245 networkRequest.setFromDiskCache(); 244 networkRequest.setFromDiskCache();
246 networkRequest.timing = response.timing; 245 networkRequest.timing = response.timing;
247 246
248 networkRequest.protocol = response.protocol; 247 networkRequest.protocol = response.protocol;
249 248
250 networkRequest.setSecurityState(response.securityState); 249 networkRequest.setSecurityState(response.securityState);
251 250
252 if (!this._mimeTypeIsConsistentWithType(networkRequest)) { 251 if (!this._mimeTypeIsConsistentWithType(networkRequest)) {
253 var consoleModel = this._manager._target.consoleModel; 252 var consoleModel = this._manager.target().model(SDK.ConsoleModel);
254 consoleModel.addMessage(new SDK.ConsoleMessage( 253 consoleModel.addMessage(new SDK.ConsoleMessage(
255 consoleModel.target(), SDK.ConsoleMessage.MessageSource.Network, SDK.C onsoleMessage.MessageLevel.Info, 254 consoleModel.target(), SDK.ConsoleMessage.MessageSource.Network, SDK.C onsoleMessage.MessageLevel.Info,
256 Common.UIString( 255 Common.UIString(
257 'Resource interpreted as %s but transferred with MIME type %s: "%s ".', 256 'Resource interpreted as %s but transferred with MIME type %s: "%s ".',
258 networkRequest.resourceType().title(), networkRequest.mimeType, ne tworkRequest.url()), 257 networkRequest.resourceType().title(), networkRequest.mimeType, ne tworkRequest.url()),
259 SDK.ConsoleMessage.MessageType.Log, '', 0, 0, networkRequest.requestId ())); 258 undefined, undefined, undefined, undefined, networkRequest.requestId() ));
260 } 259 }
261 260
262 if (response.securityDetails) 261 if (response.securityDetails)
263 networkRequest.setSecurityDetails(response.securityDetails); 262 networkRequest.setSecurityDetails(response.securityDetails);
264 } 263 }
265 264
266 /** 265 /**
267 * @param {!SDK.NetworkRequest} networkRequest 266 * @param {!SDK.NetworkRequest} networkRequest
268 * @return {boolean} 267 * @return {boolean}
269 */ 268 */
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 eventData.lastModified = lastModifiedHeader ? new Date(lastModifiedHeader) : null; 382 eventData.lastModified = lastModifiedHeader ? new Date(lastModifiedHeader) : null;
384 this._manager.dispatchEventToListeners(SDK.NetworkManager.Events.RequestUp dateDropped, eventData); 383 this._manager.dispatchEventToListeners(SDK.NetworkManager.Events.RequestUp dateDropped, eventData);
385 return; 384 return;
386 } 385 }
387 386
388 networkRequest.responseReceivedTime = time; 387 networkRequest.responseReceivedTime = time;
389 networkRequest.setResourceType(Common.resourceTypes[resourceType]); 388 networkRequest.setResourceType(Common.resourceTypes[resourceType]);
390 389
391 // net::ParsedCookie::kMaxCookieSize = 4096 (net/cookies/parsed_cookie.h) 390 // net::ParsedCookie::kMaxCookieSize = 4096 (net/cookies/parsed_cookie.h)
392 if ('Set-Cookie' in response.headers && response.headers['Set-Cookie'].lengt h > 4096) { 391 if ('Set-Cookie' in response.headers && response.headers['Set-Cookie'].lengt h > 4096) {
393 Common.console.warn(Common.UIString( 392 var consoleModel = this._manager.target().model(SDK.ConsoleModel);
394 'Set-Cookie header is ignored in response from url: %s. Cookie length should be less then or equal to 4096 characters.', 393 consoleModel.addMessage(
395 response.url)); 394 new SDK.ConsoleMessage(
395 consoleModel.target(), SDK.ConsoleMessage.MessageSource.Network, S DK.ConsoleMessage.MessageLevel.Warning,
396 Common.UIString(
397 'Set-Cookie header is ignored in response from url: %s. Cookie length should be less then or equal to 4096 characters.',
398 response.url)),
399 undefined, undefined, undefined, undefined, requestId);
396 } 400 }
397 401
398 this._updateNetworkRequestWithResponse(networkRequest, response); 402 this._updateNetworkRequestWithResponse(networkRequest, response);
399 403
400 this._updateNetworkRequest(networkRequest); 404 this._updateNetworkRequest(networkRequest);
401 this._manager.dispatchEventToListeners(SDK.NetworkManager.Events.ResponseRec eived, networkRequest); 405 this._manager.dispatchEventToListeners(SDK.NetworkManager.Events.ResponseRec eived, networkRequest);
402 } 406 }
403 407
404 /** 408 /**
405 * @override 409 * @override
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
447 var networkRequest = this._inflightRequestsById[requestId]; 451 var networkRequest = this._inflightRequestsById[requestId];
448 if (!networkRequest) 452 if (!networkRequest)
449 return; 453 return;
450 454
451 networkRequest.failed = true; 455 networkRequest.failed = true;
452 networkRequest.setResourceType(Common.resourceTypes[resourceType]); 456 networkRequest.setResourceType(Common.resourceTypes[resourceType]);
453 networkRequest.canceled = !!canceled; 457 networkRequest.canceled = !!canceled;
454 if (blockedReason) { 458 if (blockedReason) {
455 networkRequest.setBlockedReason(blockedReason); 459 networkRequest.setBlockedReason(blockedReason);
456 if (blockedReason === Protocol.Network.BlockedReason.Inspector) { 460 if (blockedReason === Protocol.Network.BlockedReason.Inspector) {
457 var consoleModel = this._manager._target.consoleModel; 461 var consoleModel = this._manager.target().model(SDK.ConsoleModel);
458 consoleModel.addMessage(new SDK.ConsoleMessage( 462 consoleModel.addMessage(new SDK.ConsoleMessage(
459 consoleModel.target(), SDK.ConsoleMessage.MessageSource.Network, SDK .ConsoleMessage.MessageLevel.Warning, 463 consoleModel.target(), SDK.ConsoleMessage.MessageSource.Network, SDK .ConsoleMessage.MessageLevel.Warning,
460 Common.UIString('Request was blocked by DevTools: "%s".', networkReq uest.url()), 464 Common.UIString('Request was blocked by DevTools: "%s".', networkReq uest.url()), undefined, undefined,
461 SDK.ConsoleMessage.MessageType.Log, '', 0, 0, networkRequest.request Id())); 465 undefined, undefined, requestId));
462 } 466 }
463 } 467 }
464 networkRequest.localizedFailDescription = localizedDescription; 468 networkRequest.localizedFailDescription = localizedDescription;
465 this._finishNetworkRequest(networkRequest, time, -1); 469 this._finishNetworkRequest(networkRequest, time, -1);
466 } 470 }
467 471
468 /** 472 /**
469 * @override 473 * @override
470 * @param {!Protocol.Network.RequestId} requestId 474 * @param {!Protocol.Network.RequestId} requestId
471 * @param {string} requestURL 475 * @param {string} requestURL
472 * @param {!Protocol.Network.Initiator=} initiator 476 * @param {!Protocol.Network.Initiator=} initiator
473 */ 477 */
474 webSocketCreated(requestId, requestURL, initiator) { 478 webSocketCreated(requestId, requestURL, initiator) {
475 var networkRequest = 479 var networkRequest =
476 new SDK.NetworkRequest(this._manager._target, requestId, requestURL, '', '', '', initiator || null); 480 new SDK.NetworkRequest(this._manager.target(), requestId, requestURL, '' , '', '', initiator || null);
477 networkRequest.setResourceType(Common.resourceTypes.WebSocket); 481 networkRequest.setResourceType(Common.resourceTypes.WebSocket);
478 this._startNetworkRequest(networkRequest); 482 this._startNetworkRequest(networkRequest);
479 } 483 }
480 484
481 /** 485 /**
482 * @override 486 * @override
483 * @param {!Protocol.Network.RequestId} requestId 487 * @param {!Protocol.Network.RequestId} requestId
484 * @param {!Protocol.Network.Timestamp} time 488 * @param {!Protocol.Network.Timestamp} time
485 * @param {!Protocol.Network.Timestamp} wallTime 489 * @param {!Protocol.Network.Timestamp} wallTime
486 * @param {!Protocol.Network.WebSocketRequest} request 490 * @param {!Protocol.Network.WebSocketRequest} request
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
662 666
663 /** 667 /**
664 * @param {!Protocol.Network.RequestId} requestId 668 * @param {!Protocol.Network.RequestId} requestId
665 * @param {string} frameId 669 * @param {string} frameId
666 * @param {!Protocol.Network.LoaderId} loaderId 670 * @param {!Protocol.Network.LoaderId} loaderId
667 * @param {string} url 671 * @param {string} url
668 * @param {string} documentURL 672 * @param {string} documentURL
669 * @param {?Protocol.Network.Initiator} initiator 673 * @param {?Protocol.Network.Initiator} initiator
670 */ 674 */
671 _createNetworkRequest(requestId, frameId, loaderId, url, documentURL, initiato r) { 675 _createNetworkRequest(requestId, frameId, loaderId, url, documentURL, initiato r) {
672 return new SDK.NetworkRequest(this._manager._target, requestId, url, documen tURL, frameId, loaderId, initiator); 676 return new SDK.NetworkRequest(this._manager.target(), requestId, url, docume ntURL, frameId, loaderId, initiator);
673 } 677 }
674 }; 678 };
675 679
676 /** 680 /**
677 * @implements {SDK.TargetManager.Observer} 681 * @implements {SDK.TargetManager.Observer}
678 * @unrestricted 682 * @unrestricted
679 */ 683 */
680 SDK.MultitargetNetworkManager = class extends Common.Object { 684 SDK.MultitargetNetworkManager = class extends Common.Object {
681 constructor() { 685 constructor() {
682 super(); 686 super();
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
910 SDK.MultitargetNetworkManager.Events = { 914 SDK.MultitargetNetworkManager.Events = {
911 ConditionsChanged: Symbol('ConditionsChanged'), 915 ConditionsChanged: Symbol('ConditionsChanged'),
912 UserAgentChanged: Symbol('UserAgentChanged') 916 UserAgentChanged: Symbol('UserAgentChanged')
913 }; 917 };
914 918
915 919
916 /** 920 /**
917 * @type {!SDK.MultitargetNetworkManager} 921 * @type {!SDK.MultitargetNetworkManager}
918 */ 922 */
919 SDK.multitargetNetworkManager; 923 SDK.multitargetNetworkManager;
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698