third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html - Issue 2675823002: Convert DelayNode tests to testharness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html

Issue 2675823002: Convert DelayNode tests to testharness (Closed)

Patch Set: Remove commented-out code. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html ('K') | « third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html

index 255d329aa1f3c45e704b577fb2f4c190b252cf95..881ee20e17fb8128300140c80320f71f09dcc9c7 100644

--- a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html

+++ b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html

@@ -2,28 +2,20 @@

<html>

<head>

-<script src="../../resources/js-test.js"></script>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

-<script src="../resources/audio-testing.js"></script>

+<script src="../resources/audit.js"></script>

</head>

<body>

-<div id="description"></div>

-<div id="console"></div>

-description("Tests that DelayNode delayTime parameter can be scheduled at a given time.");

+let audit = Audit.createTaskRunner();

+audit.define("test", function (task, should) {

+ task.describe("DelayNode delayTime parameter can be scheduled at a given time");

-function runTest() {

- if (window.testRunner) {

- testRunner.dumpAsText();

- testRunner.waitUntilDone();

- }

- window.jsTestIsAsync = true;

// Create offline audio context.

var context = new OfflineAudioContext(1, sampleRate * renderLengthSeconds, sampleRate);

var toneBuffer = createToneBuffer(context, 20, 20 * toneLengthSeconds, sampleRate); // 20Hz tone

@@ -40,11 +32,12 @@ function runTest() {

delay.connect(context.destination);

bufferSource.start(0);

- context.oncomplete = checkDelayedResult(toneBuffer);

- context.startRendering();

+ context.startRendering()

+ .then(buffer => checkDelayedResult(buffer, toneBuffer, should))

+ .then(task.done.bind(task));

hongchan 2017/02/06 17:20:28 ditto.

Raymond Toy 2017/02/06 18:41:36 Done.

+});

-runTest();

+audit.run();

</script>