Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/android/webapk/webapk_installer.cc

Issue 2675803004: Fall back to shortcut A2HS when Phonesky is out of date or unavailable. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.cc
diff --git a/chrome/browser/android/webapk/webapk_installer.cc b/chrome/browser/android/webapk/webapk_installer.cc
index 784fb5821048580e86d3b67fee73baf90abf6d49..685f190a2b2cb9b72d83385192539017b5eeae31 100644
--- a/chrome/browser/android/webapk/webapk_installer.cc
+++ b/chrome/browser/android/webapk/webapk_installer.cc
@@ -424,10 +424,12 @@ void WebApkInstaller::OnURLFetchComplete(const net::URLFetcher* source) {
if (CanUseGooglePlayInstallService()) {
int version = 1;
base::StringToInt(response->version(), &version);
- if (!InstallOrUpdateWebApkFromGooglePlay(response->package_name(), version,
- response->token())) {
- OnFailure();
- }
+ // TODO(hanxi): crbug.com/688759. Remove the return value of
+ // InstallOrUpdateWebApkFromGooglePlay(), since a callback will be called
+ // asynchronously after the install or upidate has either failed or
+ // completed.
+ InstallOrUpdateWebApkFromGooglePlay(response->package_name(), version,
+ response->token());
return;
}
« no previous file with comments | « chrome/browser/android/webapk/chrome_webapk_host.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698