Fall back to shortcut A2HS when Phonesky is out of date or unavailable.

chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/guid.h"
 #include "base/location.h"
@@ skipping 35 matching lines @@
 namespace banners {
 
 // static
 bool AppBannerInfoBarDelegateAndroid::Create(
     content::WebContents* web_contents,
     base::WeakPtr<AppBannerManager> weak_manager,
     const base::string16& app_title,
     std::unique_ptr<ShortcutInfo> shortcut_info,
     std::unique_ptr<SkBitmap> icon,
     int event_request_id,
+    bool can_use_webapk_install_flow,
     webapk::InstallSource webapk_install_source) {
-  bool is_webapk = ChromeWebApkHost::AreWebApkEnabled();
+  bool is_webapk_enabled = ChromeWebApkHost::AreWebApkEnabled();
   std::string webapk_package_name = "";
   const GURL& url = shortcut_info->url;
-  if (is_webapk)
+  if (is_webapk_enabled)

[pkotwicz, 2017/02/03 18:56:32]

For the sake of simplicity, I am ok with creating a homesreen shortcut if:
- WebAPKs are enabled
- The play install flow is disabled

I would rename |can_use_webapk_install_flow| to |is_webapk_enabled|

[Xi Han, 2017/02/03 22:16:20]

Yes it is complex, but I try to make it less difficult to understand why these
logic is added. Personally I would prefer to have the expected behavior for even
the corner case like this: if an webapk has installed and the app banner showns
due to bypass-engagement-check, it is nice to show the "open" button no matter
whether the google play flags is on or not.

[pkotwicz, 2017/02/03 23:05:05]

Can we instead have the simpler behavior:
"Only check whether there is an existing WebAPK when we are about to install a
WebAPK"

Thus, we will not check whether there is an existing WebAPK when we are about to
install a web app shortcut.

In particular for the case of:
- WebAPK enabled via variations or command line flag
- Google Play install enabled via variations
- Google Play install disabled via Google Play flags (gservices)
We won't check whether there is a WebAPK installed

When we are about to create a web app shortcut, we should display an "open"
banner only if a webapp is already installed. We should not care at all about
WebAPK state. We don't check whether a webapp is already installed because it
isn't possible to do this

     webapk_package_name = ShortcutHelper::QueryWebApkPackage(url);
   bool is_webapk_already_installed = !webapk_package_name.empty();
+  // We continue the WebAPK flow if there is an associated WebAPK has been
+  // installed or WebAPKs are enabled and the install flow is available.
+  bool is_webapk = is_webapk_already_installed ? true
+      : is_webapk_enabled & can_use_webapk_install_flow;
   auto infobar_delegate =
       base::WrapUnique(new banners::AppBannerInfoBarDelegateAndroid(
           weak_manager, app_title, std::move(shortcut_info), std::move(icon),
           event_request_id, is_webapk, is_webapk_already_installed,
-          webapk_install_source));
+          webapk_package_name, webapk_install_source));
   auto raw_delegate = infobar_delegate.get();
   auto infobar = base::MakeUnique<AppBannerInfoBarAndroid>(
       std::move(infobar_delegate), url, is_webapk);
   if (!InfoBarService::FromWebContents(web_contents)
            ->AddInfoBar(std::move(infobar)))
     return false;
 
   if (is_webapk) {
     if (webapk_install_source == webapk::INSTALL_SOURCE_MENU) {
       webapk::TrackInstallInfoBarShown(
@@ skipping 135 matching lines @@
 }
 
 AppBannerInfoBarDelegateAndroid::AppBannerInfoBarDelegateAndroid(
     base::WeakPtr<AppBannerManager> weak_manager,
     const base::string16& app_title,
     std::unique_ptr<ShortcutInfo> shortcut_info,
     std::unique_ptr<SkBitmap> icon,
     int event_request_id,
     bool is_webapk,
     bool is_webapk_already_installed,
+    const std::string& webapk_package_name,
     webapk::InstallSource webapk_install_source)
     : weak_manager_(weak_manager),
       app_title_(app_title),
       shortcut_info_(std::move(shortcut_info)),
       icon_(std::move(icon)),
       event_request_id_(event_request_id),
       has_user_interaction_(false),
       is_webapk_(is_webapk),
       is_webapk_already_installed_(is_webapk_already_installed),
+      webapk_package_name_(webapk_package_name),
       install_state_(INSTALL_NOT_STARTED),
       webapk_install_source_(webapk_install_source),
       weak_ptr_factory_(this) {
   DCHECK(!IsInfoEmpty(shortcut_info_));
   CreateJavaDelegate();
 }
 
 AppBannerInfoBarDelegateAndroid::AppBannerInfoBarDelegateAndroid(
     const base::string16& app_title,
     const base::android::ScopedJavaGlobalRef<jobject>& native_app_data,
@@ skipping 73 matching lines @@
   // If the WebAPK is installed and the "Open" button is clicked, open the
   // WebAPK.
   if (install_state_ == INSTALLED) {
     Java_AppBannerInfoBarDelegateAndroid_openWebApk(env, java_delegate_);
     if (is_webapk_already_installed_)
       webapk::TrackUserAction(webapk::USER_ACTION_OPEN);
     else
       webapk::TrackUserAction(webapk::USER_ACTION_INSTALLED_OPEN);
     SendBannerAccepted();
     return true;
+  } else if (is_webapk_already_installed_) {
+    // If a WebAPK has installed, but the |install_state_| hasn't changed
+    // yet, we updates the text of button on the banner, and return false to
+    // prevent the banner from disappear.
+    UpdateStateForInstalledWebAPK(webapk_package_name_);
+    return false;
   }
 
   // If the WebAPK is not installed and the "Add to Home Screen" button is
   // clicked, install the WebAPK.
   install_state_ = INSTALLING;
   webapk::TrackInstallSource(webapk_install_source_);
 
   if (TriggeredFromBanner()) {
     TrackUserResponse(USER_RESPONSE_WEB_APP_ACCEPTED);
     AppBannerSettingsHelper::RecordBannerInstallEvent(
@@ skipping 134 matching lines @@
 
   TrackDismissEvent(DISMISS_EVENT_BANNER_CLICK);
   return true;
 }
 
 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace banners