Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: chrome/browser/chromeos/file_manager/volume_manager.h

Issue 267573005: UMA stats for MTP file system in Chrome OS Files.app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address the review comment. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_manager/volume_manager.h
diff --git a/chrome/browser/chromeos/file_manager/volume_manager.h b/chrome/browser/chromeos/file_manager/volume_manager.h
index 492d387da0726d0acbce839e0900ce85f5901450..4d7c4509f4c7cdd1d7b57f85db271018de61935d 100644
--- a/chrome/browser/chromeos/file_manager/volume_manager.h
+++ b/chrome/browser/chromeos/file_manager/volume_manager.h
@@ -40,17 +40,21 @@ namespace file_manager {
class MountedDiskMonitor;
class VolumeManagerObserver;
-// This manager manages "Drive" and "Downloads" in addition to disks managed
-// by DiskMountManager.
+// Identifiers for volume types managed by Chrome OS file manager.
enum VolumeType {
- VOLUME_TYPE_GOOGLE_DRIVE,
+ VOLUME_TYPE_TESTING = -1, // Used only in tests.
+ VOLUME_TYPE_GOOGLE_DRIVE = 0,
VOLUME_TYPE_DOWNLOADS_DIRECTORY,
VOLUME_TYPE_REMOVABLE_DISK_PARTITION,
VOLUME_TYPE_MOUNTED_ARCHIVE_FILE,
VOLUME_TYPE_CLOUD_DEVICE,
VOLUME_TYPE_PROVIDED, // File system provided by the FileSystemProvider API.
VOLUME_TYPE_MTP,
- VOLUME_TYPE_TESTING
+ // The enum values must be kept in sync with FileManagerVolumeType in
+ // tools/metrics/histograms/histograms.xml. Since enums for histograms are
+ // append-only (for keeping the number consistent across versions), new values
+ // for this enum also has to be always appended at the end (i.e., here).
+ NUM_VOLUME_TYPE,
};
struct VolumeInfo {

Powered by Google App Engine
This is Rietveld 408576698