Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 267573003: remove unneeded SK_SUPPORT_LEGACY_PROCXFERMODE (Closed)

Created:
6 years, 7 months ago by reed1
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove unneeded SK_SUPPORT_LEGACY_PROCXFERMODE BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
will remove it from the chrome GN file next
6 years, 7 months ago (2014-04-30 21:20:55 UTC) #1
f(malita)
lgtm
6 years, 7 months ago (2014-04-30 21:23:23 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-04-30 21:24:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/267573003/1
6 years, 7 months ago (2014-04-30 21:25:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 21:25:20 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-04-30 21:25:20 UTC) #6
fmalita_google_do_not_use
lgtm
6 years, 7 months ago (2014-04-30 21:26:50 UTC) #7
fmalita_google_do_not_use
The CQ bit was checked by fmalita@google.com
6 years, 7 months ago (2014-04-30 21:26:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/267573003/1
6 years, 7 months ago (2014-04-30 21:27:13 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 21:34:16 UTC) #10
Message was sent while issue was closed.
Change committed as 14489

Powered by Google App Engine
This is Rietveld 408576698