Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: media/audio/audio_system_impl.cc

Issue 2675713002: Switch Speech Recognition to asynchronous callback-based AudioManager interactions. (Closed)
Patch Set: review comments addressed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_system_impl.cc
diff --git a/media/audio/audio_system_impl.cc b/media/audio/audio_system_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..96300ba950df9e3c3cef1f2acd9ac369fd0b1be6
--- /dev/null
+++ b/media/audio/audio_system_impl.cc
@@ -0,0 +1,70 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/audio/audio_system_impl.h"
+
+#include "base/memory/ptr_util.h"
+#include "base/single_thread_task_runner.h"
+#include "base/task_runner_util.h"
+#include "media/audio/audio_manager.h"
+
+// Using base::Unretained for |audio_manager_| is safe since it is deleted after
+// its task runner, and AudioSystemImpl is deleted on the UI thread after the IO
+// thread has been stopped and before |audio_manager_| deletion is scheduled.
+namespace media {
+
+namespace {
+
+AudioParameters GetInputParametersOnDeviceThread(AudioManager* audio_manager,
+ const std::string& device_id) {
+ DCHECK(audio_manager->GetTaskRunner()->BelongsToCurrentThread());
+
+ // TODO(olka): remove this when AudioManager::GetInputStreamParameters()
+ // works this way on all the platforms.
+ if (!audio_manager->HasAudioInputDevices())
+ return AudioParameters();
+
+ return audio_manager->GetInputStreamParameters(device_id);
+}
+
+} // namespace
+
+AudioSystemImpl::AudioSystemImpl(AudioManager* audio_manager)
+ : audio_manager_(audio_manager) {
+ DCHECK(audio_manager_);
+}
+
+AudioSystemImpl::~AudioSystemImpl() {}
+
+// static
+std::unique_ptr<AudioSystem> AudioSystemImpl::Create(
+ AudioManager* audio_manager) {
+ return base::WrapUnique(new AudioSystemImpl(audio_manager));
+}
+
+void AudioSystemImpl::GetInputStreamParameters(
+ const std::string& device_id,
+ OnAudioParamsCallback on_params_cb) const {
+ if (GetTaskRunner()->BelongsToCurrentThread()) {
+ GetTaskRunner()->PostTask(
+ FROM_HERE, base::Bind(on_params_cb, GetInputParametersOnDeviceThread(
+ audio_manager_, device_id)));
+ return;
+ }
+ base::PostTaskAndReplyWithResult(
+ GetTaskRunner(), FROM_HERE,
+ base::Bind(&GetInputParametersOnDeviceThread,
+ base::Unretained(audio_manager_), device_id),
+ std::move(on_params_cb));
+}
+
+AudioManager* AudioSystemImpl::GetAudioManager() const {
+ return audio_manager_;
+}
+
+base::SingleThreadTaskRunner* AudioSystemImpl::GetTaskRunner() const {
+ return audio_manager_->GetTaskRunner();
+}
+
+} // namespace media

Powered by Google App Engine
This is Rietveld 408576698