Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: ios/web_view/internal/criwv_web_view_internal.h

Issue 2675633002: Let CRIWVWebView inherit UIView instead of NSObject. (Closed)
Patch Set: Fix format. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/criwv_web_view_internal.h
diff --git a/ios/web_view/internal/criwv_web_view_impl.h b/ios/web_view/internal/criwv_web_view_internal.h
similarity index 67%
rename from ios/web_view/internal/criwv_web_view_impl.h
rename to ios/web_view/internal/criwv_web_view_internal.h
index fbd9170e9ab082c8b473e93215212f296da232d6..a6eebba84c13df0d3d4874eabdffbb7bfac6dda9 100644
--- a/ios/web_view/internal/criwv_web_view_impl.h
+++ b/ios/web_view/internal/criwv_web_view_internal.h
@@ -11,12 +11,11 @@ namespace ios_web_view {
class CRIWVBrowserState;
}
-@interface CRIWVWebViewImpl : NSObject<CRIWVWebView>
+@interface CRIWVWebView ()
-- (instancetype)init NS_UNAVAILABLE;
-
-- (instancetype)initWithBrowserState:
- (ios_web_view::CRIWVBrowserState*)browserState NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithFrame:(CGRect)frame
Eugene But (OOO till 7-30) 2017/02/02 20:54:32 Could you please document that |browserState| can
Hiroshi Ichikawa 2017/02/03 02:14:57 Done.
+ browserState:(ios_web_view::CRIWVBrowserState*)browserState
+ NS_DESIGNATED_INITIALIZER;
@end

Powered by Google App Engine
This is Rietveld 408576698