content/browser/loader/buffered_resource_handler.cc - Issue 267563004: Avoid issuing a Read() after draining a request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/buffered_resource_handler.cc

Issue 267563004: Avoid issuing a Read() after draining a request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add reliable repro of crash. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/buffered_resource_handler.cc

diff --git a/content/browser/loader/buffered_resource_handler.cc b/content/browser/loader/buffered_resource_handler.cc

index d5cabe35d4b0105f2c7002353dfa14da96d124bc..97c260baf5073ed35ff131568cbbb6384218c3b1 100644

--- a/content/browser/loader/buffered_resource_handler.cc

+++ b/content/browser/loader/buffered_resource_handler.cc

@@ -459,7 +459,7 @@ bool BufferedResourceHandler::HasSupportingPlugin(bool* stale) {

}

bool BufferedResourceHandler::CopyReadBufferToNextHandler(int request_id) {

- if (!bytes_read_)

+ if (!read_buffer_.get())

return true;

scoped_refptr<net::IOBuffer> buf;