pkg/front_end/lib/src/fasta/source/source_class_builder.dart - Issue 2675603002: Reduce strong mode errors and warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/source/source_class_builder.dart

Issue 2675603002: Reduce strong mode errors and warnings (Closed)

Patch Set: don't override isAbstract, it's already defined in ModifierBuilder Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/fasta/source/source_class_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/source/source_class_builder.dart b/pkg/front_end/lib/src/fasta/source/source_class_builder.dart

index 1ec438d3eea2861f8c8cb41590b8f88b575624a1..1601f7496d0f4a3a241a3cdbe2c05e015c751a0d 100644

--- a/pkg/front_end/lib/src/fasta/source/source_class_builder.dart

+++ b/pkg/front_end/lib/src/fasta/source/source_class_builder.dart

@@ -100,7 +100,9 @@ class SourceClassBuilder extends KernelClassBuilder {

int convertConstructors(KernelLibraryBuilder library) {

List<String> oldConstructorNames = <String>[];

- members.forEach((String name, MemberBuilder builder) {

+ // TODO(sigmund): should be `covariant MemberBuilder`

+ members.forEach((String name, dynamic b) {

+ MemberBuilder builder = b;

if (isConstructorName(name, this.name)) {

oldConstructorNames.add(name);

String newName = "";