Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: pkg/front_end/lib/src/fasta/parser/parser.dart

Issue 2675603002: Reduce strong mode errors and warnings (Closed)
Patch Set: comments & cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/parser/parser.dart
diff --git a/pkg/front_end/lib/src/fasta/parser/parser.dart b/pkg/front_end/lib/src/fasta/parser/parser.dart
index 8de8da74f5a97ae6d7b161b50caf6bc8f27f2b05..8f917ec4c1b777af9d77ed033b534de2bcebb4b6 100644
--- a/pkg/front_end/lib/src/fasta/parser/parser.dart
+++ b/pkg/front_end/lib/src/fasta/parser/parser.dart
@@ -2451,8 +2451,9 @@ class Parser {
Token parseParenthesizedExpression(Token token) {
// We expect [begin] to be of type [BeginGroupToken], but we don't know for
// sure until after calling expect.
- var begin = token;
+ var first = token;
token = expect('(', token);
+ BeginGroupToken begin = first;
ahe 2017/02/07 11:03:08 I would rather keep the previous version using "dy
Siggi Cherem (dart-lang) 2017/02/07 21:59:26 Done.
// [begin] is now known to have type [BeginGroupToken].
token = parseExpression(token);
if (!identical(begin.endGroup, token)) {

Powered by Google App Engine
This is Rietveld 408576698