Reduce strong mode errors and warnings

pkg/front_end/lib/src/fasta/analyzer/mock_type.dart

Index: pkg/front_end/lib/src/fasta/analyzer/mock_type.dart
diff --git a/pkg/front_end/lib/src/fasta/analyzer/mock_type.dart b/pkg/front_end/lib/src/fasta/analyzer/mock_type.dart
index ce34190cd9d8900ff910e3078d3d10a92988ade4..c8b412e54f6fe6c9229519e115d33e98dc4f14df 100644
--- a/pkg/front_end/lib/src/fasta/analyzer/mock_type.dart
+++ b/pkg/front_end/lib/src/fasta/analyzer/mock_type.dart
@@ -36,7 +36,8 @@ abstract class MockType extends DartType {
 
   String get name => internalError("not supported.");
 
-  DartType flattenFutures(TypeSystem typeSystem) => internalError("not supported.");
+  DartType flattenFutures(TypeSystem typeSystem) =>
+      internalError("not supported.");

[ahe, 2017/02/07 11:03:07]

Would you mind using `{ return expr; }` when `=> expr;` doesn't fit on one line?

[Siggi Cherem (dart-lang), 2017/02/07 21:59:25]

Sure, no problem.

FWIW - I personally prefer to continue using => when the rhs is a simple
expression.

[ahe, 2017/02/08 19:59:23]

Let's pick the option that most people on team prefer and stick to that. I'm
used to what I suggested above, and kinda like it.

[Siggi Cherem (dart-lang), 2017/02/09 04:44:02]

OK - I'll land this for now as you suggested since likely the rest of the code
is following this style, we can revisit this later on if we need to.

 
   bool isAssignableTo(DartType type) => internalError("not supported.");
 
@@ -46,20 +47,27 @@ abstract class MockType extends DartType {
 
   bool isSupertypeOf(DartType type) => internalError("not supported.");
 
-  DartType resolveToBound(DartType objectType) => internalError("not supported.");
+  DartType resolveToBound(DartType objectType) =>
+      internalError("not supported.");
 
   DartType substitute2(
-      List<DartType> argumentTypes, List<DartType> parameterTypes) => internalError("not supported.");
+      List<DartType> argumentTypes, List<DartType> parameterTypes) =>
+        internalError("not supported.");
 
   List<DartType> get typeArguments => internalError("not supported.");
 
-  List<TypeParameterElement> get typeParameters => internalError("not supported.");
+  List<TypeParameterElement> get typeParameters =>
+      internalError("not supported.");
 
-  ParameterizedType instantiate(List<DartType> argumentTypes) => internalError("not supported.");
+  ParameterizedType instantiate(List<DartType> argumentTypes) =>
+      internalError("not supported.");
 }
 
 abstract class MockInterfaceType extends MockType implements InterfaceType {
-  List<PropertyAccessorElement> get accessors => internalError("not supported.");
+  ClassElement get element => internalError("not supported.");
+
+  List<PropertyAccessorElement> get accessors =>
+      internalError("not supported.");
 
   List<ConstructorElement> get constructors => internalError("not supported.");
 
@@ -71,44 +79,63 @@ abstract class MockInterfaceType extends MockType implements InterfaceType {
 
   InterfaceType get superclass => internalError("not supported.");
 
-  PropertyAccessorElement getGetter(String name) => internalError("not supported.");
+  PropertyAccessorElement getGetter(String name) =>
+      internalError("not supported.");
 
   MethodElement getMethod(String name) => internalError("not supported.");
 
-  PropertyAccessorElement getSetter(String name) => internalError("not supported.");
+  PropertyAccessorElement getSetter(String name) =>
+      internalError("not supported.");
 
-  bool isDirectSupertypeOf(InterfaceType type) => internalError("not supported.");
+  bool isDirectSupertypeOf(InterfaceType type) =>
+      internalError("not supported.");
 
 
-  ConstructorElement lookUpConstructor(String name, LibraryElement library) => internalError("not supported.");
+  ConstructorElement lookUpConstructor(String name, LibraryElement library) =>
+      internalError("not supported.");
 
-  PropertyAccessorElement lookUpGetter(String name, LibraryElement library) => internalError("not supported.");
+  PropertyAccessorElement lookUpGetter(String name, LibraryElement library) =>
+      internalError("not supported.");
 
   PropertyAccessorElement lookUpGetterInSuperclass(
       String name, LibraryElement library) => internalError("not supported.");
 
   PropertyAccessorElement lookUpInheritedGetter(String name,
-      {LibraryElement library, bool thisType: true}) => internalError("not supported.");
+      {LibraryElement library, bool thisType: true}) =>
+          internalError("not supported.");
 
   ExecutableElement lookUpInheritedGetterOrMethod(String name,
       {LibraryElement library}) => internalError("not supported.");
 
   MethodElement lookUpInheritedMethod(String name,
-      {LibraryElement library, bool thisType: true}) => internalError("not supported.");
+      {LibraryElement library, bool thisType: true}) =>
+          internalError("not supported.");
 
   PropertyAccessorElement lookUpInheritedSetter(String name,
-      {LibraryElement library, bool thisType: true}) => internalError("not supported.");
+      {LibraryElement library, bool thisType: true}) =>
+          internalError("not supported.");
 
-  MethodElement lookUpMethod(String name, LibraryElement library) => internalError("not supported.");
+  MethodElement lookUpMethod(String name, LibraryElement library) =>
+      internalError("not supported.");
 
-  MethodElement lookUpMethodInSuperclass(String name, LibraryElement library) => internalError("not supported.");
+  MethodElement lookUpMethodInSuperclass(String name, LibraryElement library) =>
+      internalError("not supported.");
 
-  PropertyAccessorElement lookUpSetter(String name, LibraryElement library) => internalError("not supported.");
+  PropertyAccessorElement lookUpSetter(String name, LibraryElement library) =>
+      internalError("not supported.");
 
   PropertyAccessorElement lookUpSetterInSuperclass(
       String name, LibraryElement library) => internalError("not supported.");
 
-  InterfaceType substitute4(List<DartType> argumentTypes) => internalError("not supported.");
+  InterfaceType instantiate(List<DartType> argumentTypes) =>
+      internalError("not supported.");
+
+  InterfaceType substitute2(
+      List<DartType> argumentTypes, List<DartType> parameterTypes) =>
+          internalError("not supported.");
+
+  InterfaceType substitute4(List<DartType> argumentTypes) =>
+      internalError("not supported.");
 
   get isDartCoreNull => internalError("not supported.");
 }