Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart

Issue 2675603002: Reduce strong mode errors and warnings (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
index 8728eafb7ae48d744b59b6af3ff14f8f82f87887..0df0d384e5c2caa49d793605a052a39510b19bd3 100644
--- a/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
@@ -10,6 +10,9 @@ export 'frontend_accessors.dart' show
import 'frontend_accessors.dart' show
Accessor;
+import 'package:meta/meta.dart' show
+ virtual;
+
import 'package:kernel/ast.dart';
import 'package:kernel/core_types.dart' show
@@ -97,7 +100,7 @@ abstract class BuilderAccessor implements Accessor {
isSetter: true);
}
- Expression doInvocation(int charOffset, Arguments arguments);
+ doInvocation(int charOffset, Arguments arguments);
ahe 2017/02/02 07:28:30 Please don't remove explicit types.
Siggi Cherem (dart-lang) 2017/02/02 16:30:35 There is a subclass that returns a non-expression
Siggi Cherem (dart-lang) 2017/02/06 23:35:50 To be specific `ThisAccessor` might return an Init
buildPropertyAccess(IncompleteSend send, bool isNullAware) {
if (send is SendAccessor) {
@@ -287,7 +290,7 @@ abstract class IncompleteSend extends BuilderAccessor {
final int charOffset;
- final Name name;
+ @virtual final Name name;
IncompleteSend(this.helper, this.charOffset, this.name);

Powered by Google App Engine
This is Rietveld 408576698