Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: pkg/front_end/lib/src/fasta/builder/type_declaration_builder.dart

Issue 2675603002: Reduce strong mode errors and warnings (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/type_declaration_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/type_declaration_builder.dart b/pkg/front_end/lib/src/fasta/builder/type_declaration_builder.dart
index b3948c9e98016ec12e539ef47d1663974edcdb83..a5a05bbbe5071229585c2719910cd8d2161c6abf 100644
--- a/pkg/front_end/lib/src/fasta/builder/type_declaration_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/type_declaration_builder.dart
@@ -10,6 +10,9 @@ import 'builder.dart' show
ModifierBuilder,
TypeBuilder;
+import 'package:meta/meta.dart' show
+ virtual;
+
abstract class TypeDeclarationBuilder<T extends TypeBuilder, R>
extends ModifierBuilder {
final List<MetadataBuilder> metadata;
@@ -20,7 +23,8 @@ abstract class TypeDeclarationBuilder<T extends TypeBuilder, R>
final List<T> types;
- Builder parent;
+ // TODO(sigmund): remove @virtual, should not be needed, see #28601
ahe 2017/02/02 07:28:30 I'm patient. I can wait until issue 28601 is fixed
Siggi Cherem (dart-lang) 2017/02/02 16:30:35 I understand, note that it's a 1-file package with
+ @virtual Builder parent;
TypeDeclarationBuilder(this.metadata, this.modifiers, this.name, this.types,
this.parent);

Powered by Google App Engine
This is Rietveld 408576698