Reduce strong mode errors and warnings

pkg/front_end/lib/src/fasta/scanner/recover.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style licenset hat can be found in the LICENSE file.
 
 library fasta.scanner.recover;
 
 import 'token.dart' show
     StringToken,
     Token;
 
@@ skipping 36 matching lines @@
   /// Used for appending to [good].
   Token goodTail;
 
   /// The previous token appended to [good]. Since tokens are single linked
   /// lists, this allows us to rewrite the current token without scanning all
   /// of [good]. This is supposed to be the token immediately before
   /// [goodTail], that is, `beforeGoodTail.next == goodTail`.
   Token beforeGoodTail;
 
   recoverIdentifier(NonAsciiIdentifierToken first) {
-    List codeUnits = <int>[];
+    var codeUnits = <int>[];

[ahe, 2017/02/07 11:03:08]

Restore type.

[Siggi Cherem (dart-lang), 2017/02/07 21:59:26]

Done.

Not sure if you know: in strong mode `var` gets inferred with the type of the
rhs, in this case List<int>, so it was treated as such below whether I include
the type or var.

Just to double check: do you prefer the type to be explicit in this case? Or
would you be OK omitting it given that we know it is inferred?

[ahe, 2017/02/08 19:59:24]

Thank you. I prefer for types to be explicit as I can't see the inferred type in
Emacs and code reviews.

 
     // True if the previous good token is an identifier and ends right where
     // [first] starts. This is the case for input like `blåbærgrød`. In this
     // case, the scanner produces this sequence of tokens:
     //
     //     [
     //        StringToken("bl"),
     //        NonAsciiIdentifierToken("å"),
     //        StringToken("b"),
     //        NonAsciiIdentifierToken("æ"),
@@ skipping 171 matching lines @@
 
 String closeBraceFor(String openBrace) {
   return const {
     '(': ')',
     '[': ']',
     '{': '}',
     '<': '>',
     r'${': '}',
   }[openBrace];
 }