Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: pkg/front_end/lib/src/fasta/builder/library_builder.dart

Issue 2675603002: Reduce strong mode errors and warnings (Closed)
Patch Set: comments & cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.library_builder; 5 library fasta.library_builder;
6 6
7 import '../combinator.dart' show 7 import '../combinator.dart' show
8 Combinator; 8 Combinator;
9 9
10 import '../errors.dart' show 10 import '../errors.dart' show
11 InputError; 11 InputError;
12 12
13 import '../export.dart' show 13 import '../export.dart' show
14 Export; 14 Export;
15 15
16 import '../loader.dart' show 16 import '../loader.dart' show
17 Loader; 17 Loader;
18 18
19 import 'builder.dart' show 19 import 'builder.dart' show
20 Builder, 20 Builder,
21 InvalidTypeBuilder,
22 TypeBuilder; 21 TypeBuilder;
23 22
24 import 'scope.dart' show 23 import 'scope.dart' show
25 Scope; 24 Scope;
26 25
27 abstract class LibraryBuilder<T extends TypeBuilder, R> extends Builder { 26 abstract class LibraryBuilder<T extends TypeBuilder, R> extends Builder {
28 final List<Export> exporters = <Export>[]; 27 final List<Export> exporters = <Export>[];
29 28
30 final List<InputError> compileTimeErrors = <InputError>[]; 29 final List<InputError> compileTimeErrors = <InputError>[];
31 30
(...skipping 21 matching lines...) Expand all
53 void addCompileTimeError(int charOffset, Object message) { 52 void addCompileTimeError(int charOffset, Object message) {
54 InputError error = new InputError(uri, charOffset, message); 53 InputError error = new InputError(uri, charOffset, message);
55 compileTimeErrors.add(error); 54 compileTimeErrors.add(error);
56 print(error.format()); 55 print(error.format());
57 } 56 }
58 57
59 bool addToExportScope(String name, Builder member); 58 bool addToExportScope(String name, Builder member);
60 59
61 void addToScope(String name, Builder member); 60 void addToScope(String name, Builder member);
62 61
63 InvalidTypeBuilder buildAmbiguousBuilder( 62 Builder buildAmbiguousBuilder(
64 String name, Builder builder, Builder other); 63 String name, Builder builder, Builder other);
65 64
66 int finishStaticInvocations() => 0; 65 int finishStaticInvocations() => 0;
67 } 66 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698