Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: net/spdy/buffered_spdy_framer_unittest.cc

Issue 2675593002: Spdy{RstStream,GoAway}Status -> SpdyErrorCode. (Closed)
Patch Set: Merged master, which includes 145087791. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/http2_frame_decoder_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/buffered_spdy_framer_unittest.cc
diff --git a/net/spdy/buffered_spdy_framer_unittest.cc b/net/spdy/buffered_spdy_framer_unittest.cc
index b0a4472a973c134b2e291780075d853ee243605a..aba9a5c94caf75ca9b73c644da2e5033a7553a76 100644
--- a/net/spdy/buffered_spdy_framer_unittest.cc
+++ b/net/spdy/buffered_spdy_framer_unittest.cc
@@ -81,15 +81,14 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {
void OnPing(SpdyPingId unique_id, bool is_ack) override {}
- void OnRstStream(SpdyStreamId stream_id,
- SpdyRstStreamStatus status) override {}
+ void OnRstStream(SpdyStreamId stream_id, SpdyErrorCode error_code) override {}
void OnGoAway(SpdyStreamId last_accepted_stream_id,
- SpdyGoAwayStatus status,
+ SpdyErrorCode error_code,
base::StringPiece debug_data) override {
goaway_count_++;
goaway_last_accepted_stream_id_ = last_accepted_stream_id;
- goaway_status_ = status;
+ goaway_error_code_ = error_code;
goaway_debug_data_.assign(debug_data.data(), debug_data.size());
}
@@ -167,7 +166,7 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {
// OnGoAway parameters.
SpdyStreamId goaway_last_accepted_stream_id_;
- SpdyGoAwayStatus goaway_status_;
+ SpdyErrorCode goaway_error_code_;
std::string goaway_debug_data_;
// OnAltSvc parameters.
@@ -264,7 +263,7 @@ TEST_F(BufferedSpdyFramerTest, ReadPushPromiseHeaderBlock) {
TEST_F(BufferedSpdyFramerTest, GoAwayDebugData) {
BufferedSpdyFramer framer;
std::unique_ptr<SpdySerializedFrame> goaway_frame(
- framer.CreateGoAway(2u, GOAWAY_FRAME_SIZE_ERROR, "foo"));
+ framer.CreateGoAway(2u, ERROR_CODE_FRAME_SIZE_ERROR, "foo"));
TestBufferedSpdyVisitor visitor;
visitor.SimulateInFramer(
@@ -273,7 +272,7 @@ TEST_F(BufferedSpdyFramerTest, GoAwayDebugData) {
EXPECT_EQ(0, visitor.error_count_);
EXPECT_EQ(1, visitor.goaway_count_);
EXPECT_EQ(2u, visitor.goaway_last_accepted_stream_id_);
- EXPECT_EQ(GOAWAY_FRAME_SIZE_ERROR, visitor.goaway_status_);
+ EXPECT_EQ(ERROR_CODE_FRAME_SIZE_ERROR, visitor.goaway_error_code_);
EXPECT_EQ("foo", visitor.goaway_debug_data_);
}
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/http2_frame_decoder_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698