Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 2675553002: Removed instances of fprintf in run_vm_tests and replaced them with OS::Print/PrintErr. (Closed)

Created:
3 years, 10 months ago by bkonyi
Modified:
3 years, 10 months ago
Reviewers:
rmacnak, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removed instances of fprintf in run_vm_tests and replaced them with OS::Print/PrintErr. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/ed4bf4f2e093091ae652ee4b9f3c485a0439e797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M runtime/bin/run_vm_tests.cc View 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bkonyi
As discussed during a CL yesterday, I've changed the fprintf instances in run_vm_tests to their ...
3 years, 10 months ago (2017-02-02 01:06:54 UTC) #2
Cutch
lgtm
3 years, 10 months ago (2017-02-02 14:54:19 UTC) #4
bkonyi
3 years, 10 months ago (2017-02-02 17:43:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ed4bf4f2e093091ae652ee4b9f3c485a0439e797 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698