milo: Use service interface for swarming.

milo/appengine/swarming/build_test.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package swarming
 
 import (
         "encoding/json"
         "flag"
         "fmt"
         "io/ioutil"
-        "path"
+        "path/filepath"
         "testing"
         "time"
 
         "github.com/luci/luci-go/common/clock/testclock"
+
+        "golang.org/x/net/context"
+
         . "github.com/smartystreets/goconvey/convey"
-        "golang.org/x/net/context"
 )
 
 var generate = flag.Bool("test.generate", false, "Generate expectations instead of running tests.")
 
 func load(name string) ([]byte, error) {
-        filename := path.Join("expectations", name)
+        filename := filepath.Join("expectations", name)
         return ioutil.ReadFile(filename)
 }
 
 func shouldMatchExpectationsFor(actualContents interface{}, expectedFilename ...interface{}) string {
         refBuild, err := load(expectedFilename[0].(string))
         if err != nil {
                 return fmt.Sprintf("Could not load %s: %s", expectedFilename[0], err.Error())
         }
         actualBuild, err := json.MarshalIndent(actualContents, "", "  ")
         return ShouldEqual(string(actualBuild), string(refBuild))
 
 }
 
 func TestBuild(t *testing.T) {
         c := context.Background()
         c, _ = testclock.UseTime(c, time.Date(2016, time.March, 14, 11, 0, 0, 0, time.UTC))
 
+        var svc debugSwarmingService
         if *generate {
                 for _, tc := range getTestCases() {
                         fmt.Printf("Generating expectations for %s\n", tc)
-                        build, err := swarmingBuildImpl(c, "foo", "debug", tc)
+
+                        build, err := swarmingBuildImpl(c, svc, "foo", tc)
                         if err != nil {
                                 panic(fmt.Errorf("Could not run swarmingBuildImpl for %s: %s", tc, err))
                         }
                         buildJSON, err := json.MarshalIndent(build, "", "  ")
                         if err != nil {
                                 panic(fmt.Errorf("Could not JSON marshal %s: %s", tc, err))
                         }
-                        filename := path.Join("expectations", tc+".json")
+                        filename := filepath.Join("expectations", tc+".json")
                         err = ioutil.WriteFile(filename, []byte(buildJSON), 0644)
                         if err != nil {
                                 panic(fmt.Errorf("Encountered error while trying to write to %s: %s", filename, err))
                         }
                 }
                 return
         }
 
         Convey(`A test Environment`, t, func() {
                 for _, tc := range getTestCases() {
                         Convey(fmt.Sprintf("Test Case: %s", tc), func() {
-                                build, err := swarmingBuildImpl(c, "foo", "debug", tc)
+                                build, err := swarmingBuildImpl(c, svc, "foo", tc)
                                 So(err, ShouldBeNil)
                                 So(build, shouldMatchExpectationsFor, tc+".json")
                         })
                 }
         })
 }