Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5726)

Unified Diff: chrome/browser/permissions/permission_decision_auto_blocker.cc

Issue 2675483002: Replace PermissionType in chrome/ with ContentSettingsType (Closed)
Patch Set: rebase + include content_settings_types.h more Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_decision_auto_blocker.cc
diff --git a/chrome/browser/permissions/permission_decision_auto_blocker.cc b/chrome/browser/permissions/permission_decision_auto_blocker.cc
index f8ab89c4ca566987f47f46b2bca75552a48fa3ef..017553d86979890252a23167b3a7b425e08415a0 100644
--- a/chrome/browser/permissions/permission_decision_auto_blocker.cc
+++ b/chrome/browser/permissions/permission_decision_auto_blocker.cc
@@ -22,7 +22,6 @@
#include "components/keyed_service/content/browser_context_dependency_manager.h"
#include "components/safe_browsing_db/database_manager.h"
#include "components/variations/variations_associated_data.h"
-#include "content/public/browser/permission_type.h"
#include "content/public/browser/web_contents.h"
#include "url/gurl.h"
@@ -74,7 +73,7 @@ base::DictionaryValue* GetOrCreatePermissionDict(
}
int RecordActionInWebsiteSettings(const GURL& url,
- content::PermissionType permission,
+ ContentSettingsType permission,
const char* key,
Profile* profile) {
HostContentSettingsMap* map =
@@ -96,7 +95,7 @@ int RecordActionInWebsiteSettings(const GURL& url,
}
int GetActionCount(const GURL& url,
- content::PermissionType permission,
+ ContentSettingsType permission,
const char* key,
Profile* profile) {
HostContentSettingsMap* map =
@@ -206,19 +205,19 @@ void PermissionDecisionAutoBlocker::RemoveCountsByUrl(
int PermissionDecisionAutoBlocker::GetDismissCount(
const GURL& url,
- content::PermissionType permission) {
+ ContentSettingsType permission) {
return GetActionCount(url, permission, kPromptDismissCountKey, profile_);
}
int PermissionDecisionAutoBlocker::GetIgnoreCount(
const GURL& url,
- content::PermissionType permission) {
+ ContentSettingsType permission) {
return GetActionCount(url, permission, kPromptIgnoreCountKey, profile_);
}
bool PermissionDecisionAutoBlocker::RecordDismissAndEmbargo(
const GURL& url,
- content::PermissionType permission) {
+ ContentSettingsType permission) {
int current_dismissal_count = RecordActionInWebsiteSettings(
url, permission, kPromptDismissCountKey, profile_);
@@ -232,7 +231,7 @@ bool PermissionDecisionAutoBlocker::RecordDismissAndEmbargo(
int PermissionDecisionAutoBlocker::RecordIgnore(
const GURL& url,
- content::PermissionType permission) {
+ ContentSettingsType permission) {
return RecordActionInWebsiteSettings(url, permission, kPromptIgnoreCountKey,
profile_);
}
@@ -267,7 +266,7 @@ void PermissionDecisionAutoBlocker::UpdateFromVariations() {
}
void PermissionDecisionAutoBlocker::UpdateEmbargoedStatus(
- content::PermissionType permission,
+ ContentSettingsType permission,
const GURL& request_origin,
content::WebContents* web_contents,
base::Callback<void(bool)> callback) {
@@ -291,7 +290,7 @@ void PermissionDecisionAutoBlocker::UpdateEmbargoedStatus(
}
bool PermissionDecisionAutoBlocker::IsUnderEmbargo(
- content::PermissionType permission,
+ ContentSettingsType permission,
const GURL& request_origin) {
HostContentSettingsMap* map =
HostContentSettingsMapFactory::GetForProfile(profile_);
@@ -328,7 +327,7 @@ bool PermissionDecisionAutoBlocker::IsUnderEmbargo(
}
void PermissionDecisionAutoBlocker::CheckSafeBrowsingResult(
- content::PermissionType permission,
+ ContentSettingsType permission,
const GURL& request_origin,
base::Callback<void(bool)> callback,
bool should_be_embargoed) {
@@ -342,7 +341,7 @@ void PermissionDecisionAutoBlocker::CheckSafeBrowsingResult(
}
void PermissionDecisionAutoBlocker::PlaceUnderEmbargo(
- content::PermissionType permission,
+ ContentSettingsType permission,
const GURL& request_origin,
const char* key) {
HostContentSettingsMap* map =

Powered by Google App Engine
This is Rietveld 408576698