Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: chrome/browser/safe_browsing/permission_reporter_unittest.cc

Issue 2675483002: Replace PermissionType in chrome/ with ContentSettingsType (Closed)
Patch Set: rebase + include content_settings_types.h more Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/permission_reporter.h" 5 #include "chrome/browser/safe_browsing/permission_reporter.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/metrics/field_trial.h" 8 #include "base/metrics/field_trial.h"
9 #include "base/test/scoped_feature_list.h" 9 #include "base/test/scoped_feature_list.h"
10 #include "base/test/simple_test_clock.h" 10 #include "base/test/simple_test_clock.h"
11 #include "base/time/time.h" 11 #include "base/time/time.h"
12 #include "chrome/browser/permissions/permission_request.h" 12 #include "chrome/browser/permissions/permission_request.h"
13 #include "chrome/browser/safe_browsing/mock_permission_report_sender.h" 13 #include "chrome/browser/safe_browsing/mock_permission_report_sender.h"
14 #include "chrome/common/safe_browsing/permission_report.pb.h" 14 #include "chrome/common/safe_browsing/permission_report.pb.h"
15 #include "components/variations/active_field_trials.h" 15 #include "components/variations/active_field_trials.h"
16 #include "content/public/browser/permission_type.h"
17 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
18 17
19 using content::PermissionType;
20
21 namespace safe_browsing { 18 namespace safe_browsing {
22 19
23 namespace { 20 namespace {
24 21
25 // URL to upload permission action reports. 22 // URL to upload permission action reports.
26 const char kPermissionActionReportingUploadUrl[] = 23 const char kPermissionActionReportingUploadUrl[] =
27 "https://safebrowsing.googleusercontent.com/safebrowsing/clientreport/" 24 "https://safebrowsing.googleusercontent.com/safebrowsing/clientreport/"
28 "chrome-permissions"; 25 "chrome-permissions";
29 26
30 const int kMaximumReportsPerOriginPerPermissionPerMinute = 5; 27 const int kMaximumReportsPerOriginPerPermissionPerMinute = 5;
31 28
32 const char kDummyOriginOne[] = "http://example.test/"; 29 const char kDummyOriginOne[] = "http://example.test/";
33 const char kDummyOriginTwo[] = "http://example2.test/"; 30 const char kDummyOriginTwo[] = "http://example2.test/";
34 const PermissionType kDummyPermissionOne = PermissionType::GEOLOCATION; 31 const ContentSettingsType kDummyPermissionOne =
35 const PermissionType kDummyPermissionTwo = PermissionType::NOTIFICATIONS; 32 CONTENT_SETTINGS_TYPE_GEOLOCATION;
33 const ContentSettingsType kDummyPermissionTwo =
34 CONTENT_SETTINGS_TYPE_NOTIFICATIONS;
36 const PermissionAction kDummyAction = GRANTED; 35 const PermissionAction kDummyAction = GRANTED;
37 const PermissionSourceUI kDummySourceUI = PermissionSourceUI::PROMPT; 36 const PermissionSourceUI kDummySourceUI = PermissionSourceUI::PROMPT;
38 const PermissionRequestGestureType kDummyGestureType = 37 const PermissionRequestGestureType kDummyGestureType =
39 PermissionRequestGestureType::GESTURE; 38 PermissionRequestGestureType::GESTURE;
40 const PermissionPersistDecision kDummyPersistDecision = 39 const PermissionPersistDecision kDummyPersistDecision =
41 PermissionPersistDecision::PERSISTED; 40 PermissionPersistDecision::PERSISTED;
42 const int kDummyNumPriorDismissals = 10; 41 const int kDummyNumPriorDismissals = 10;
43 const int kDummyNumPriorIgnores = 12; 42 const int kDummyNumPriorIgnores = 12;
44 43
45 const char kDummyTrialOne[] = "trial one"; 44 const char kDummyTrialOne[] = "trial one";
46 const char kDummyGroupOne[] = "group one"; 45 const char kDummyGroupOne[] = "group one";
47 const char kDummyTrialTwo[] = "trial two"; 46 const char kDummyTrialTwo[] = "trial two";
48 const char kDummyGroupTwo[] = "group two"; 47 const char kDummyGroupTwo[] = "group two";
49 48
50 constexpr char kFeatureOnByDefaultName[] = "OnByDefault"; 49 constexpr char kFeatureOnByDefaultName[] = "OnByDefault";
51 struct base::Feature kFeatureOnByDefault { 50 struct base::Feature kFeatureOnByDefault {
52 kFeatureOnByDefaultName, base::FEATURE_ENABLED_BY_DEFAULT 51 kFeatureOnByDefaultName, base::FEATURE_ENABLED_BY_DEFAULT
53 }; 52 };
54 53
55 constexpr char kFeatureOffByDefaultName[] = "OffByDefault"; 54 constexpr char kFeatureOffByDefaultName[] = "OffByDefault";
56 struct base::Feature kFeatureOffByDefault { 55 struct base::Feature kFeatureOffByDefault {
57 kFeatureOffByDefaultName, base::FEATURE_DISABLED_BY_DEFAULT 56 kFeatureOffByDefaultName, base::FEATURE_DISABLED_BY_DEFAULT
58 }; 57 };
59 58
60 PermissionReportInfo BuildDummyReportInfo(const char* requesting_origin, 59 PermissionReportInfo BuildDummyReportInfo(const char* requesting_origin,
61 PermissionType permission) { 60 ContentSettingsType permission) {
62 PermissionReportInfo info(GURL(requesting_origin), permission, kDummyAction, 61 PermissionReportInfo info(GURL(requesting_origin), permission, kDummyAction,
63 kDummySourceUI, kDummyGestureType, kDummyPersistDecision, 62 kDummySourceUI, kDummyGestureType, kDummyPersistDecision,
64 kDummyNumPriorDismissals, kDummyNumPriorIgnores); 63 kDummyNumPriorDismissals, kDummyNumPriorIgnores);
65 64
66 return info; 65 return info;
67 } 66 }
68 67
69 PermissionReportInfo BuildDummyReportInfo() { 68 PermissionReportInfo BuildDummyReportInfo() {
70 return BuildDummyReportInfo(kDummyOriginOne, kDummyPermissionOne); 69 return BuildDummyReportInfo(kDummyOriginOne, kDummyPermissionOne);
71 } 70 }
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 reports_to_send = 12; 209 reports_to_send = 12;
211 while (reports_to_send--) { 210 while (reports_to_send--) {
212 clock_->Advance(base::TimeDelta::FromSeconds(5)); 211 clock_->Advance(base::TimeDelta::FromSeconds(5));
213 permission_reporter_->SendReport(BuildDummyReportInfo()); 212 permission_reporter_->SendReport(BuildDummyReportInfo());
214 } 213 }
215 EXPECT_EQ(kMaximumReportsPerOriginPerPermissionPerMinute, 214 EXPECT_EQ(kMaximumReportsPerOriginPerPermissionPerMinute,
216 mock_report_sender_->GetAndResetNumberOfReportsSent()); 215 mock_report_sender_->GetAndResetNumberOfReportsSent());
217 } 216 }
218 217
219 } // namespace safe_browsing 218 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter.cc ('k') | chrome/browser/safe_browsing/ping_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698