Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/permissions/permission_request_impl.cc

Issue 2675483002: Replace PermissionType in chrome/ with ContentSettingsType (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_request_impl.h" 5 #include "chrome/browser/permissions/permission_request_impl.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/permissions/permission_uma_util.h" 8 #include "chrome/browser/permissions/permission_uma_util.h"
9 #include "chrome/browser/permissions/permission_util.h" 9 #include "chrome/browser/permissions/permission_util.h"
10 #include "chrome/grit/generated_resources.h" 10 #include "chrome/grit/generated_resources.h"
11 #include "components/url_formatter/elide_url.h" 11 #include "components/url_formatter/elide_url.h"
12 #include "net/base/escape.h" 12 #include "net/base/escape.h"
13 #include "ui/base/l10n/l10n_util.h" 13 #include "ui/base/l10n/l10n_util.h"
14 #include "ui/gfx/vector_icons_public.h" 14 #include "ui/gfx/vector_icons_public.h"
15 15
16 #if defined(OS_ANDROID) 16 #if defined(OS_ANDROID)
17 #include "chrome/browser/android/android_theme_resources.h" 17 #include "chrome/browser/android/android_theme_resources.h"
18 #endif 18 #endif
19 19
20 PermissionRequestImpl::PermissionRequestImpl( 20 PermissionRequestImpl::PermissionRequestImpl(
21 const GURL& request_origin, 21 const GURL& request_origin,
22 content::PermissionType permission_type, 22 ContentSettingsType content_settings_type,
23 Profile* profile, 23 Profile* profile,
24 bool has_gesture, 24 bool has_gesture,
25 const PermissionDecidedCallback& permission_decided_callback, 25 const PermissionDecidedCallback& permission_decided_callback,
26 const base::Closure delete_callback) 26 const base::Closure delete_callback)
27 : request_origin_(request_origin), 27 : request_origin_(request_origin),
28 permission_type_(permission_type), 28 content_settings_type_(content_settings_type),
29 profile_(profile), 29 profile_(profile),
30 has_gesture_(has_gesture), 30 has_gesture_(has_gesture),
31 permission_decided_callback_(permission_decided_callback), 31 permission_decided_callback_(permission_decided_callback),
32 delete_callback_(delete_callback), 32 delete_callback_(delete_callback),
33 is_finished_(false), 33 is_finished_(false),
34 action_taken_(false) {} 34 action_taken_(false) {}
35 35
36 PermissionRequestImpl::~PermissionRequestImpl() { 36 PermissionRequestImpl::~PermissionRequestImpl() {
37 DCHECK(is_finished_); 37 DCHECK(is_finished_);
38 if (!action_taken_) { 38 if (!action_taken_) {
39 PermissionUmaUtil::PermissionIgnored(permission_type_, GetGestureType(), 39 PermissionUmaUtil::PermissionIgnored(
40 request_origin_, profile_); 40 content_settings_type_, GetGestureType(), request_origin_, profile_);
41 } 41 }
42 } 42 }
43 43
44 PermissionRequest::IconId PermissionRequestImpl::GetIconId() const { 44 PermissionRequest::IconId PermissionRequestImpl::GetIconId() const {
45 #if defined(OS_ANDROID) 45 #if defined(OS_ANDROID)
46 switch (permission_type_) { 46 switch (content_settings_type_) {
47 case content::PermissionType::GEOLOCATION: 47 case CONTENT_SETTINGS_TYPE_GEOLOCATION:
48 return IDR_ANDROID_INFOBAR_GEOLOCATION; 48 return IDR_ANDROID_INFOBAR_GEOLOCATION;
49 case content::PermissionType::NOTIFICATIONS: 49 case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
50 case content::PermissionType::PUSH_MESSAGING: 50 case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
51 return IDR_ANDROID_INFOBAR_NOTIFICATIONS; 51 return IDR_ANDROID_INFOBAR_NOTIFICATIONS;
52 case content::PermissionType::MIDI_SYSEX: 52 case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
53 return IDR_ANDROID_INFOBAR_MIDI; 53 return IDR_ANDROID_INFOBAR_MIDI;
54 case content::PermissionType::PROTECTED_MEDIA_IDENTIFIER: 54 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
55 return IDR_ANDROID_INFOBAR_PROTECTED_MEDIA_IDENTIFIER; 55 return IDR_ANDROID_INFOBAR_PROTECTED_MEDIA_IDENTIFIER;
56 default: 56 default:
57 NOTREACHED(); 57 NOTREACHED();
58 return IDR_ANDROID_INFOBAR_WARNING; 58 return IDR_ANDROID_INFOBAR_WARNING;
59 } 59 }
60 #else 60 #else
61 switch (permission_type_) { 61 switch (content_settings_type_) {
62 case content::PermissionType::GEOLOCATION: 62 case CONTENT_SETTINGS_TYPE_GEOLOCATION:
63 return gfx::VectorIconId::LOCATION_ON; 63 return gfx::VectorIconId::LOCATION_ON;
64 case content::PermissionType::NOTIFICATIONS: 64 case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
65 case content::PermissionType::PUSH_MESSAGING: 65 case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
66 return gfx::VectorIconId::NOTIFICATIONS; 66 return gfx::VectorIconId::NOTIFICATIONS;
67 #if defined(OS_CHROMEOS) 67 #if defined(OS_CHROMEOS)
68 // TODO(xhwang): fix this icon, see crrev.com/863263007 68 // TODO(xhwang): fix this icon, see crrev.com/863263007
69 case content::PermissionType::PROTECTED_MEDIA_IDENTIFIER: 69 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
70 return gfx::VectorIconId::PRODUCT; 70 return gfx::VectorIconId::PRODUCT;
71 #endif 71 #endif
72 case content::PermissionType::MIDI_SYSEX: 72 case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
73 return gfx::VectorIconId::MIDI; 73 return gfx::VectorIconId::MIDI;
74 case content::PermissionType::FLASH: 74 case CONTENT_SETTINGS_TYPE_PLUGINS:
75 return gfx::VectorIconId::EXTENSION; 75 return gfx::VectorIconId::EXTENSION;
76 default: 76 default:
77 NOTREACHED(); 77 NOTREACHED();
78 return gfx::VectorIconId::VECTOR_ICON_NONE; 78 return gfx::VectorIconId::VECTOR_ICON_NONE;
79 } 79 }
80 #endif 80 #endif
81 } 81 }
82 82
83 base::string16 PermissionRequestImpl::GetMessageTextFragment() const { 83 base::string16 PermissionRequestImpl::GetMessageTextFragment() const {
84 int message_id; 84 int message_id;
85 switch (permission_type_) { 85 switch (content_settings_type_) {
86 case content::PermissionType::GEOLOCATION: 86 case CONTENT_SETTINGS_TYPE_GEOLOCATION:
87 message_id = IDS_GEOLOCATION_INFOBAR_PERMISSION_FRAGMENT; 87 message_id = IDS_GEOLOCATION_INFOBAR_PERMISSION_FRAGMENT;
88 break; 88 break;
89 case content::PermissionType::NOTIFICATIONS: 89 case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
90 case content::PermissionType::PUSH_MESSAGING: 90 case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
91 message_id = IDS_NOTIFICATION_PERMISSIONS_FRAGMENT; 91 message_id = IDS_NOTIFICATION_PERMISSIONS_FRAGMENT;
92 break; 92 break;
93 case content::PermissionType::MIDI_SYSEX: 93 case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
94 message_id = IDS_MIDI_SYSEX_PERMISSION_FRAGMENT; 94 message_id = IDS_MIDI_SYSEX_PERMISSION_FRAGMENT;
95 break; 95 break;
96 #if defined(OS_CHROMEOS) 96 #if defined(OS_CHROMEOS)
97 case content::PermissionType::PROTECTED_MEDIA_IDENTIFIER: 97 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
98 message_id = IDS_PROTECTED_MEDIA_IDENTIFIER_PERMISSION_FRAGMENT; 98 message_id = IDS_PROTECTED_MEDIA_IDENTIFIER_PERMISSION_FRAGMENT;
99 break; 99 break;
100 #endif 100 #endif
101 case content::PermissionType::FLASH: 101 case CONTENT_SETTINGS_TYPE_PLUGINS:
102 message_id = IDS_FLASH_PERMISSION_FRAGMENT; 102 message_id = IDS_FLASH_PERMISSION_FRAGMENT;
103 break; 103 break;
104 default: 104 default:
105 NOTREACHED(); 105 NOTREACHED();
106 return base::string16(); 106 return base::string16();
107 } 107 }
108 return l10n_util::GetStringUTF16(message_id); 108 return l10n_util::GetStringUTF16(message_id);
109 } 109 }
110 110
111 GURL PermissionRequestImpl::GetOrigin() const { 111 GURL PermissionRequestImpl::GetOrigin() const {
(...skipping 14 matching lines...) Expand all
126 RegisterActionTaken(); 126 RegisterActionTaken();
127 permission_decided_callback_.Run(false, CONTENT_SETTING_DEFAULT); 127 permission_decided_callback_.Run(false, CONTENT_SETTING_DEFAULT);
128 } 128 }
129 129
130 void PermissionRequestImpl::RequestFinished() { 130 void PermissionRequestImpl::RequestFinished() {
131 is_finished_ = true; 131 is_finished_ = true;
132 delete_callback_.Run(); 132 delete_callback_.Run();
133 } 133 }
134 134
135 bool PermissionRequestImpl::ShouldShowPersistenceToggle() const { 135 bool PermissionRequestImpl::ShouldShowPersistenceToggle() const {
136 return (permission_type_ == content::PermissionType::GEOLOCATION) && 136 return (content_settings_type_ == CONTENT_SETTINGS_TYPE_GEOLOCATION) &&
137 PermissionUtil::ShouldShowPersistenceToggle(); 137 PermissionUtil::ShouldShowPersistenceToggle();
138 } 138 }
139 139
140 PermissionRequestType PermissionRequestImpl::GetPermissionRequestType() 140 PermissionRequestType PermissionRequestImpl::GetPermissionRequestType()
141 const { 141 const {
142 return PermissionUtil::GetRequestType(permission_type_); 142 return PermissionUtil::GetRequestType(content_settings_type_);
143 } 143 }
144 144
145 PermissionRequestGestureType PermissionRequestImpl::GetGestureType() 145 PermissionRequestGestureType PermissionRequestImpl::GetGestureType()
146 const { 146 const {
147 return PermissionUtil::GetGestureType(has_gesture_); 147 return PermissionUtil::GetGestureType(has_gesture_);
148 } 148 }
149
150 ContentSettingsType PermissionRequestImpl::GetContentSettingsType() const {
151 switch (permission_type_) {
152 case content::PermissionType::GEOLOCATION:
153 return CONTENT_SETTINGS_TYPE_GEOLOCATION;
154 case content::PermissionType::PUSH_MESSAGING:
155 case content::PermissionType::NOTIFICATIONS:
156 return CONTENT_SETTINGS_TYPE_NOTIFICATIONS;
157 case content::PermissionType::MIDI_SYSEX:
158 return CONTENT_SETTINGS_TYPE_MIDI_SYSEX;
159 #if defined(OS_CHROMEOS)
160 case content::PermissionType::PROTECTED_MEDIA_IDENTIFIER:
161 return CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER;
162 #endif
163 case content::PermissionType::FLASH:
164 return CONTENT_SETTINGS_TYPE_PLUGINS;
165 default:
166 NOTREACHED();
167 return CONTENT_SETTINGS_TYPE_DEFAULT;
168 }
169 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698