Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2675473002: [Gardening] Update dart2js host-checked status for circular_factory_redirection_test (Closed)

Created:
3 years, 10 months ago by hausner
Modified:
3 years, 10 months ago
Reviewers:
regis, ahe
CC:
reviews_dartlang.org, ahe
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update dart2js host-checked status for circular_factory_redirection_test Test circular_factory_redirection_test/02 no longer crashes, probably a side effect of the new Fasta front-end. BUG= Committed: https://github.com/dart-lang/sdk/commit/90ed8e9d273a5af58cd3b7ec69d3dbdce315859e

Patch Set 1 #

Patch Set 2 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
hausner
TBR(ubberstamped)=regis
3 years, 10 months ago (2017-02-01 22:35:19 UTC) #3
hausner
Committed patchset #2 (id:20001) manually as 90ed8e9d273a5af58cd3b7ec69d3dbdce315859e (presubmit successful).
3 years, 10 months ago (2017-02-01 22:35:55 UTC) #5
regis
lgtm
3 years, 10 months ago (2017-02-01 22:37:43 UTC) #6
ahe
3 years, 10 months ago (2017-02-02 14:50:00 UTC) #8
Message was sent while issue was closed.
Thank you for fixing this.

I took a look, and it was indeed due to fasta. However, the change has to do
with error recovery from non-factory factories. I don't think that is what the
test was supposed to test, so I've created CL 2669233002 to fix the test.

Powered by Google App Engine
This is Rietveld 408576698