Language settings: Fix unnecessarily shown move buttons

chrome/test/data/webui/settings/languages_page_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for settings-languages-page. */
 
 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
@@ skipping 55 matching lines @@
       return new Promise(function(resolve, reject) {
         languagesPage.addEventListener('languages-changed', function changed() {
           if (languagesPage.languages.enabled.length != numExpected)
             return;
           resolve();
           languagesPage.removeEventListener('languages-changed', changed);
         });
       });
     }
 
-    // Returns a supported language that is not enabled, for testing.
-    function getAvailableLanguage() {
-      return languagesPage.languages.supported.find(function(language) {
+    // Returns supported languages that are not enabled.
+    function getAvailableLanguages() {
+      return languagesPage.languages.supported.filter(function(language) {
         return !languageHelper.isLanguageEnabled(language.code);
       });
     }
 
     suiteSetup(function() {
       page.set('pageVisibility.languages', true);
       Polymer.dom.flush();
 
       languagesSection = assert(this.getSection(page, 'languages'));
       languagesPage = assert(
@@ skipping 106 matching lines @@
         MockInteractions.tap(actionButton);
 
         // Wait for the languages to be enabled by the browser.
         return whenNumEnabledLanguagesBecomes(numEnabled + 2);
       });
     });
 
     suite('language menu', function() {
       var origTranslateEnabled;
 
+      /**
+       * Finds, asserts and returns the menu item for the given i18n key.
+       * @param {string} i18nKey Name of the i18n string for the item's text.
+       * @return {!HTMLElement} Menu item.
+       */
+      function getMenuItem(i18nKey) {
+        var i18nString = assert(loadTimeData.getString(i18nKey));
+        var menuItems = actionMenu.querySelectorAll('.dropdown-item');
+        var menuItem = Array.from(menuItems).find(
+            item => item.textContent.trim() == i18nString);
+        return assert(menuItem, 'Menu item "' + i18nKey + '" not found');
+      }
+
+      /**
+       * Checks the visibility of each expected menu item button.
+       * param {!Object<boolean>} Dictionary from i18n keys to expected
+       *     visibility of those menu items.
+       */
+      function assertMenuItemButtonsVisible(buttonVisibility) {
+        assertTrue(actionMenu.open);
+        for (var buttonKey of Object.keys(buttonVisibility)) {
+          var buttonItem = getMenuItem(buttonKey);
+          assertEquals(!buttonVisibility[buttonKey], buttonItem.hidden,
+                       'Menu item "' + buttonKey + '" hidden');
+        }
+      }
+
       suiteSetup(function() {
         // Cache the value of Translate to avoid side effects.
         origTranslateEnabled = languageHelper.prefs.translate.enabled.value;
       });
 
       suiteTeardown(function() {
         var cur = languageHelper.prefs.translate.enabled.value;
         // Restore the value of Translate.
         languageHelper.setPrefValue('translate.enabled', origTranslateEnabled);
         cur = languageHelper.prefs.translate.enabled.value;
@@ skipping 26 matching lines @@
         languagesPage.set('languages.translateTarget', 'foo');
         languagesPage.set('languages.enabled.1.supportsTranslate', true);
 
         var languageOptionsDropdownTrigger =
             languagesCollapse.querySelectorAll('paper-icon-button')[1];
         assertTrue(!!languageOptionsDropdownTrigger);
         MockInteractions.tap(languageOptionsDropdownTrigger);
         assertTrue(actionMenu.open);
 
         // Toggle the translate option.
-        var translateOption = actionMenu.querySelector('#offerTranslations');
-        assertTrue(!!translateOption);
+        var translateOption = getMenuItem('offerToTranslateInThisLanguage');
         assertFalse(translateOption.disabled);
         MockInteractions.tap(translateOption);
 
         // Menu should stay open briefly.
         assertTrue(actionMenu.open);
         // Guaranteed to run later than the menu close delay.
         setTimeout(function() {
           assertFalse(actionMenu.open);
           done();
         }, settings.kMenuCloseDelay + 1);
       });
 
       test('remove language', function() {
         var numEnabled = languagesPage.languages.enabled.length;
 
         // Enabled a language which we can then disable.
-        var newLanguage = getAvailableLanguage();
+        var newLanguage = assert(getAvailableLanguages()[0]);
         languageHelper.enableLanguage(newLanguage.code);
 
         // Wait for the language to be enabled.
         return whenNumEnabledLanguagesBecomes(numEnabled + 1).then(function() {
           // Populate the dom-repeat.
           Polymer.dom.flush();
 
           // Find the new language item.
           var items = languagesCollapse.querySelectorAll('.list-item');
           var domRepeat = assert(
               languagesCollapse.querySelector('template[is="dom-repeat"]'));
           var item = Array.from(items).find(function(el) {
             return domRepeat.itemForElement(el) &&
                 domRepeat.itemForElement(el).language == newLanguage;
           });
 
           // Open the menu and select Remove.
           MockInteractions.tap(item.querySelector('paper-icon-button'));
 
           assertTrue(actionMenu.open);
-          var removeMenuItem = assert(actionMenu.querySelector(
-              '.dropdown-item:last-child'));
+          var removeMenuItem = getMenuItem('removeLanguage');
           assertFalse(removeMenuItem.disabled);
           MockInteractions.tap(removeMenuItem);
           assertFalse(actionMenu.open);
 
           // We should go back down to the original number of enabled languages.
           return whenNumEnabledLanguagesBecomes(numEnabled);
         }).then(function() {
           assertFalse(languageHelper.isLanguageEnabled(newLanguage.code));
         });
       });
+
+      test('move up/down buttons', function() {
+        // Add several languages.
+        var numEnabled = languagesPage.languages.enabled.length;
+        var available = getAvailableLanguages();
+        for (var i = 0; i < 4; i++)
+          languageHelper.enableLanguage(assert(available[i]).code);
+
+        return whenNumEnabledLanguagesBecomes(numEnabled + 4).then(function() {
+          Polymer.dom.flush();
+
+          var menuButtons =
+              languagesCollapse.querySelectorAll(
+                  '.list-item paper-icon-button[icon="cr:more-vert"]');
+
+          // First language should not have "Move up" or "Move to top".
+          MockInteractions.tap(menuButtons[0]);
+          assertMenuItemButtonsVisible({
+            moveToTop: false, moveUp: false, moveDown: true,
+          });
+          actionMenu.close();
+
+          // Second language should not have "Move up".
+          MockInteractions.tap(menuButtons[1]);
+          assertMenuItemButtonsVisible({
+            moveToTop: true, moveUp: false, moveDown: true,
+          });
+          actionMenu.close();
+
+          // Middle languages should have all buttons.
+          MockInteractions.tap(menuButtons[2]);
+          assertMenuItemButtonsVisible({
+            moveToTop: true, moveUp: true, moveDown: true,
+          });
+          actionMenu.close();
+
+          // Last language should not have "Move down".
+          MockInteractions.tap(menuButtons[menuButtons.length - 1]);
+          assertMenuItemButtonsVisible({
+            moveToTop: true, moveUp: true, moveDown: false,
+          });
+          actionMenu.close();
+        });
+      });
     });
 
     test('manage input methods', function() {
       var inputMethodsCollapse = languagesPage.$.inputMethodsCollapse;
       var inputMethodSettingsExist = !!inputMethodsCollapse;
       if (cr.isChromeOS) {
         assertTrue(inputMethodSettingsExist);
         var manageInputMethodsButton =
             inputMethodsCollapse.querySelector('.list-button:last-of-type');
         MockInteractions.tap(manageInputMethodsButton);
@@ skipping 36 matching lines @@
         assertTrue(!!languagesPage.$$('settings-edit-dictionary-page'));
       }
     });
   }.bind(this));
 
   // TODO(michaelpg): Test more aspects of the languages UI.
 
   // Run all registered tests.
   mocha.run();
 });