Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2675403002: [DO NOT LAND] Add some scripts to diagnose impact of crbug.com/684270. (Closed)

Created:
3 years, 10 months ago by Wez
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke, dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT LAND] Add some scripts to diagnose impact of crbug.com/684270. Includes dpranke's script from crrev.com/2660133002 and adds some new scripts which diagnose the OWNERS coverage in different ways. rietveld_source_owners.py is the current complete script, which: - Identifies which CLs contain one or more "non-source" files[1]. - For each affected CL, checks out the preceding revision to allow OWNERS to be correctly checked against. - For each CL with one or more files missing OWNERS (i.e. neither the author, nor any approver, nor any TBR, applies to the file) collates the affected files by type (usually based on extension). BUG=684270

Patch Set 1 #

Patch Set 2 : Print out needs-OWNERS and needs-messaging commits #

Patch Set 3 : Fix caching logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+592 lines, -0 lines) Patch
A tools/rietveld_approvers_for_issue.py View 1 chunk +46 lines, -0 lines 0 comments Download
A tools/rietveld_missing_ipc_reviewers.py View 1 chunk +128 lines, -0 lines 0 comments Download
A tools/rietveld_missing_owners.py View 1 chunk +121 lines, -0 lines 0 comments Download
A tools/rietveld_source_owners.py View 1 2 1 chunk +297 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Wez
FYI, chaps.
3 years, 10 months ago (2017-02-06 22:14:20 UTC) #2
Wez
Wibble
3 years, 10 months ago (2017-02-07 01:35:13 UTC) #3
Wez
Wibble\nBibble
3 years, 10 months ago (2017-02-07 01:35:21 UTC) #4
Wez
Wibble Bibble
3 years, 10 months ago (2017-02-07 01:48:35 UTC) #5
Wez
3 years, 10 months ago (2017-02-08 18:02:20 UTC) #6
Marking this closed to get it out of my code review queue. ;)

Powered by Google App Engine
This is Rietveld 408576698