Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2675353003: Remove unused mojo_common_perftests target (Closed)

Created:
3 years, 10 months ago by scottmg
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused mojo_common_perftests target Perftests appear to be in other binaries. This is getting built, but contains no sources and doesn't get run anywhere that I can find. I also didn't see any test .cc files in this directory that it was accidentally not including. Review-Url: https://codereview.chromium.org/2675353003 Cr-Commit-Position: refs/heads/master@{#448672} Committed: https://chromium.googlesource.com/chromium/src/+/be8ad9ced3f0012b8ddcbe62f62e71ea8479ceed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
scottmg
3 years, 10 months ago (2017-02-07 18:17:52 UTC) #8
Ken Rockot(use gerrit already)
lgtm
3 years, 10 months ago (2017-02-07 18:19:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675353003/1
3 years, 10 months ago (2017-02-07 18:21:14 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 18:25:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be8ad9ced3f0012b8ddcbe62f62e...

Powered by Google App Engine
This is Rietveld 408576698