net/spdy/spdy_session.cc - Issue 2675343002: Server push cancellation: add NetLogs to track cache lookup transaction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session.cc

Issue 2675343002: Server push cancellation: add NetLogs to track cache lookup transaction (Closed)

Patch Set: address rch's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_session.cc

diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc

index a7287cdecf96f9740a1e0e9f89c7f8de61049758..81a730da54b6857673dbb1b0c932ac6d72bdb03e 100644

--- a/net/spdy/spdy_session.cc

+++ b/net/spdy/spdy_session.cc

@@ -2693,7 +2693,8 @@ void SpdySession::TryCreatePushStream(SpdyStreamId stream_id,

// Notify the push_delegate that a push promise has been received.

if (push_delegate_) {

push_delegate_->OnPush(base::MakeUnique<SpdyServerPushHelper>(

- weak_factory_.GetWeakPtr(), gurl));

+ weak_factory_.GetWeakPtr(), gurl),

+ net_log_);

}

active_it->second->OnPushPromiseHeadersReceived(std::move(headers));