net/quic/chromium/quic_chromium_client_session.cc - Issue 2675343002: Server push cancellation: add NetLogs to track cache lookup transaction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2675343002: Server push cancellation: add NetLogs to track cache lookup transaction (Closed)

Patch Set: Always log the push lookup results Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/quic_chromium_client_session.cc

diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc

index 26989fe2ca95a39d506d75e17fc3ac34367c0479..f255796e4d27dfed23e3a8236059450a9816abfd 100644

--- a/net/quic/chromium/quic_chromium_client_session.cc

+++ b/net/quic/chromium/quic_chromium_client_session.cc

@@ -1466,7 +1466,8 @@ bool QuicChromiumClientSession::HandlePromised(QuicStreamId id,

GURL pushed_url = GetUrlFromHeaderBlock(headers);

if (push_delegate_) {

push_delegate_->OnPush(base::MakeUnique<QuicServerPushHelper>(

- weak_factory_.GetWeakPtr(), pushed_url));

+ weak_factory_.GetWeakPtr(), pushed_url),

+ net_log_);

}

net_log_.AddEvent(NetLogEventType::QUIC_SESSION_PUSH_PROMISE_RECEIVED,