Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1774)

Unified Diff: net/spdy/spdy_session.cc

Issue 2675343002: Server push cancellation: add NetLogs to track cache lookup transaction (Closed)
Patch Set: fix typo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/server_push_delegate.h ('k') | net/spdy/spdy_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index a7287cdecf96f9740a1e0e9f89c7f8de61049758..245fbbe8a0d84a5ab5978b6ca37f1e58d5a0e071 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -360,7 +360,7 @@ class SpdyServerPushHelper : public ServerPushDelegate::ServerPushHelper {
session_->CancelPush(request_url_);
}
- const GURL& GetURL() override { return request_url_; }
+ const GURL& GetURL() const override { return request_url_; }
private:
base::WeakPtr<SpdySession> session_;
@@ -2693,7 +2693,8 @@ void SpdySession::TryCreatePushStream(SpdyStreamId stream_id,
// Notify the push_delegate that a push promise has been received.
if (push_delegate_) {
push_delegate_->OnPush(base::MakeUnique<SpdyServerPushHelper>(
- weak_factory_.GetWeakPtr(), gurl));
+ weak_factory_.GetWeakPtr(), gurl),
+ net_log_);
}
active_it->second->OnPushPromiseHeadersReceived(std::move(headers));
« no previous file with comments | « net/spdy/server_push_delegate.h ('k') | net/spdy/spdy_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698