Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2675343002: Server push cancellation: add NetLogs to track cache lookup transaction (Closed)
Patch Set: fix typo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/log/net_log_source_type_list.h ('k') | net/spdy/server_push_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_session.cc
diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc
index 26989fe2ca95a39d506d75e17fc3ac34367c0479..e3f4cfe626167a7698013c17320dec91f2151703 100644
--- a/net/quic/chromium/quic_chromium_client_session.cc
+++ b/net/quic/chromium/quic_chromium_client_session.cc
@@ -177,7 +177,7 @@ class QuicServerPushHelper : public ServerPushDelegate::ServerPushHelper {
}
}
- const GURL& GetURL() override { return request_url_; }
+ const GURL& GetURL() const override { return request_url_; }
private:
base::WeakPtr<QuicChromiumClientSession> session_;
@@ -1466,7 +1466,8 @@ bool QuicChromiumClientSession::HandlePromised(QuicStreamId id,
GURL pushed_url = GetUrlFromHeaderBlock(headers);
if (push_delegate_) {
push_delegate_->OnPush(base::MakeUnique<QuicServerPushHelper>(
- weak_factory_.GetWeakPtr(), pushed_url));
+ weak_factory_.GetWeakPtr(), pushed_url),
+ net_log_);
}
}
net_log_.AddEvent(NetLogEventType::QUIC_SESSION_PUSH_PROMISE_RECEIVED,
« no previous file with comments | « net/log/net_log_source_type_list.h ('k') | net/spdy/server_push_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698