Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: net/log/net_log_event_type_list.h

Issue 2675343002: Server push cancellation: add NetLogs to track cache lookup transaction (Closed)
Patch Set: address eroman's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/net_log_event_type_list.h
diff --git a/net/log/net_log_event_type_list.h b/net/log/net_log_event_type_list.h
index bfdc0945062aa2c0b5477ed72ecaf358b175a18c..ce48a0b1b4ffd7a119b320fa87ef3fddb89e6eab 100644
--- a/net/log/net_log_event_type_list.h
+++ b/net/log/net_log_event_type_list.h
@@ -1303,6 +1303,26 @@ EVENT_TYPE(BIDIRECTIONAL_STREAM_READY)
EVENT_TYPE(BIDIRECTIONAL_STREAM_FAILED)
// ------------------------------------------------------------------------
+// SERVER_PUSH_LOOKUP_TRANSACTION
+// ------------------------------------------------------------------------
+
+// The start/end of a push lookup transaction for server push.
+//
+// The START event has the parameters:
+// {
+// "source_dependency": <Source identifier for the server push lookp.
+// It can be a QUIC_SESSION or a HTTP2_SESSION>,
+// "pushed_url": <The url that has been pushed and looked up>,
+// }
+//
+// If the transaction doesn't find the resource in cache, then the END phase
eroman 2017/02/11 02:44:36 nit: de-indent this by two spaces?
Zhongyi Shi 2017/02/11 09:42:26 Done. I forgot to upload the patch set which fixes
+// has these parameters:
+// {
+// "net_error": <Net error code integer>,
+// }
+EVENT_TYPE(SERVER_PUSH_LOOKUP_TRANSACTION)
+
+// ------------------------------------------------------------------------
// SpdySession
// ------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698