content/shell/android/java/src/org/chromium/content_shell/Shell.java - Issue 26753005: Adding compositor callbacks to RenderWidgetHostViewAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/java/src/org/chromium/content_shell/Shell.java

Issue 26753005: Adding compositor callbacks to RenderWidgetHostViewAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Plumb compositor provider through instead of compositor Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/android/java/src/org/chromium/content_shell/Shell.java

diff --git a/content/shell/android/java/src/org/chromium/content_shell/Shell.java b/content/shell/android/java/src/org/chromium/content_shell/Shell.java

index f97b323d9945c226e156e5b53e3e4f04bc29b339..d2632e4686a5ceca30bc09e3b659f45b51f3b099 100644

--- a/content/shell/android/java/src/org/chromium/content_shell/Shell.java

+++ b/content/shell/android/java/src/org/chromium/content_shell/Shell.java

@@ -21,6 +21,7 @@ import android.widget.TextView.OnEditorActionListener;

import org.chromium.base.CalledByNative;

import org.chromium.base.JNINamespace;

+import org.chromium.content.browser.CompositorProvider;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewRenderView;

import org.chromium.content.browser.LoadUrlParams;

@@ -216,7 +217,9 @@ public class Shell extends LinearLayout {

@SuppressWarnings("unused")

@CalledByNative

private void initFromNativeTabContents(int nativeTabContents) {

- mContentView = ContentView.newInstance(getContext(), nativeTabContents, mWindow);

+ CompositorProvider compositorProvider = mContentViewRenderView;

+ mContentView = ContentView.newInstance(getContext(), nativeTabContents, mWindow,

+ compositorProvider);

if (mContentView.getUrl() != null) mUrlTextView.setText(mContentView.getUrl());

((FrameLayout) findViewById(R.id.contentview_holder)).addView(mContentView,

new FrameLayout.LayoutParams(

« content/browser/renderer_host/render_widget_host_view_android.cc ('K') | « content/public/browser/android/compositor_provider_client.h ('k') | no next file » | no next file with comments »