chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java - Issue 26753005: Adding compositor callbacks to RenderWidgetHostViewAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java

Issue 26753005: Adding compositor callbacks to RenderWidgetHostViewAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Plumb compositor provider through instead of compositor Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java ('k') | chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java » ('j') | content/browser/renderer_host/render_widget_host_view_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java

diff --git a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java

index 5b6753927c2692ba857d3c5453338f3d3467ed9e..fae5bf6c3d4d49b3fa0ce5eb0c0f777a2726324d 100644

--- a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java

+++ b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java

@@ -11,6 +11,7 @@ import android.view.ViewGroup;

import android.widget.FrameLayout;

import android.widget.LinearLayout;

+import org.chromium.content.browser.CompositorProvider;

import org.chromium.content.browser.ContentViewRenderView;

import org.chromium.ui.WindowAndroid;

@@ -85,7 +86,8 @@ public class TabManager extends LinearLayout {

public void createTab(String url) {

if (!isContentViewRenderViewInitialized()) return;

- TestShellTab tab = new TestShellTab(getContext(), url, mWindow);

+ CompositorProvider compositorProvider = mContentViewRenderView;

+ TestShellTab tab = new TestShellTab(getContext(), url, mWindow, compositorProvider);

setCurrentTab(tab);

}