Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/gcm_driver/gcm_client.h

Issue 2675293003: Push API: Don't wait for network when unsubscribing (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/push_messaging/push_messaging_browsertest.cc ('K') | « chrome/browser/push_messaging/push_messaging_service_impl.cc ('k') | components/gcm_driver/gcm_client_impl.cc » ('j') | components/gcm_driver/gcm_client_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_client.h
diff --git a/components/gcm_driver/gcm_client.h b/components/gcm_driver/gcm_client.h
index c4dd12adc914375e3c8cf118e114589f292a7df5..c4c9c265ec6ae60df4a1cdc32240882a6ee28844 100644
--- a/components/gcm_driver/gcm_client.h
+++ b/components/gcm_driver/gcm_client.h
@@ -51,6 +51,7 @@ class GCMClient {
IMMEDIATE_START
};
+ // Used for UMA. Can add enum values, but never renumber or delete and reuse.
enum Result {
// Successful operation.
SUCCESS,
@@ -68,7 +69,11 @@ class GCMClient {
// Exceeded the specified TTL during message sending.
TTL_EXCEEDED,
// Other errors.
- UNKNOWN_ERROR
+ UNKNOWN_ERROR,
+
+ // Used for UMA. Keep LAST_RESULT up to date and sync with histograms.xml.
+
Peter Beverloo 2017/02/07 18:11:08 micro nit: no newline
johnme 2017/02/08 14:14:36 Done.
+ LAST_RESULT = UNKNOWN_ERROR
};
enum ChromePlatform {
« chrome/browser/push_messaging/push_messaging_browsertest.cc ('K') | « chrome/browser/push_messaging/push_messaging_service_impl.cc ('k') | components/gcm_driver/gcm_client_impl.cc » ('j') | components/gcm_driver/gcm_client_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698