Push API: Don't wait for network when unsubscribing

components/gcm_driver/gcm_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_GCM_DRIVER_GCM_CLIENT_H_
 #define COMPONENTS_GCM_DRIVER_GCM_CLIENT_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 33 matching lines @@
   // and GCM store will be loaded. Then GCM connection may or may not be
   // initiated depending on this enum value.
   enum StartMode {
     // GCM should be started only when it is being actually used. If no
     // registration record is found, GCM will not kick off.
     DELAYED_START,
     // GCM should be started immediately.
     IMMEDIATE_START
   };
 
+  // Used for UMA. Can add enum values, but never renumber or delete and reuse.
   enum Result {
     // Successful operation.
     SUCCESS,
     // Invalid parameter.
     INVALID_PARAMETER,
     // GCM is disabled.
     GCM_DISABLED,
     // Previous asynchronous operation is still pending to finish. Certain
     // operation, like register, is only allowed one at a time.
     ASYNC_OPERATION_PENDING,
     // Network socket error.
     NETWORK_ERROR,
     // Problem at the server.
     SERVER_ERROR,
     // Exceeded the specified TTL during message sending.
     TTL_EXCEEDED,
     // Other errors.
-    UNKNOWN_ERROR
+    UNKNOWN_ERROR,
+
+    // Used for UMA. Keep LAST_RESULT up to date and sync with histograms.xml.
+

[Peter Beverloo, 2017/02/07 18:11:08]

micro nit: no newline

[johnme, 2017/02/08 14:14:36]

Done.

+    LAST_RESULT = UNKNOWN_ERROR
   };
 
   enum ChromePlatform {
     PLATFORM_WIN,
     PLATFORM_MAC,
     PLATFORM_LINUX,
     PLATFORM_CROS,
     PLATFORM_IOS,
     PLATFORM_ANDROID,
     PLATFORM_UNKNOWN
@@ skipping 246 matching lines @@
   // to be set, and allows that component to later revoke the setting. It should
   // be unique.
   virtual void AddHeartbeatInterval(const std::string& scope,
                                     int interval_ms) = 0;
   virtual void RemoveHeartbeatInterval(const std::string& scope) = 0;
 };
 
 }  // namespace gcm
 
 #endif  // COMPONENTS_GCM_DRIVER_GCM_CLIENT_H_