Push API: Don't wait for network when unsubscribing

chrome/browser/gcm/fake_gcm_profile_service.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GCM_FAKE_GCM_PROFILE_SERVICE_H_
 #define CHROME_BROWSER_GCM_FAKE_GCM_PROFILE_SERVICE_H_
 
 #include <list>
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "components/gcm_driver/gcm_driver.h"

[Peter Beverloo, 2017/02/07 18:11:08]

nit: IWYU means we should include the following instead:

components/gcm_driver/common/gcm_messages.h
components/gcm_driver/gcm_client.h

[johnme, 2017/02/08 14:14:36]

Done.

 #include "components/gcm_driver/gcm_profile_service.h"
 
 class Profile;
 
 namespace content {
 class BrowserContext;
 }  // namespace content
 
 namespace gcm {
 
 // Acts as a bridge between GCM API and GCMClient layer for testing purposes.
 class FakeGCMProfileService : public GCMProfileService {
  public:
-  typedef base::Callback<void(const std::string&)> UnregisterCallback;
-
   // Helper function to be used with
   // KeyedService::SetTestingFactory().
   static std::unique_ptr<KeyedService> Build(content::BrowserContext* context);
 
   explicit FakeGCMProfileService(Profile* profile);
   ~FakeGCMProfileService() override;
 
-  void RegisterFinished(const std::string& app_id,
-                        const std::vector<std::string>& sender_ids);
-  void UnregisterFinished(const std::string& app_id);
-  void SendFinished(const std::string& app_id,
-                    const std::string& receiver_id,
-                    const OutgoingMessage& message);
-
   void AddExpectedUnregisterResponse(GCMClient::Result result);
 
-  void SetUnregisterCallback(const UnregisterCallback& callback);
-
   void DispatchMessage(const std::string& app_id,
                        const IncomingMessage& message);
 
   const OutgoingMessage& last_sent_message() const {
     return last_sent_message_;
   }
 
   const std::string& last_receiver_id() const {
     return last_receiver_id_;
   }
 
   const std::string& last_registered_app_id() const {
     return last_registered_app_id_;
   }
 
   const std::vector<std::string>& last_registered_sender_ids() const {
     return last_registered_sender_ids_;
   }
 
   void set_collect(bool collect) {
     collect_ = collect;
   }
 
+  // Simple offline simulation: requests fail after max backoff.
+  void set_offline(bool is_offline) { is_offline_ = is_offline; }
+
  private:
+  class CustomFakeGCMDriver;
+  friend class CustomFakeGCMDriver;

[Peter Beverloo, 2017/02/07 18:11:08]

nit: since the CustomFakeGCMDriver already stores a pointer to the
FakeGCMProfileService*, can we avoid (a) the nested class and (b) the friend
declaration by just adding a public is_offline()?

Since this entire class is meant for testing, that seems nicer.

[johnme, 2017/02/08 14:14:36]

No, it's not just is_offline_, it's also collect_, last_registered_app_id_,
last_registered_sender_ids_, unregister_responses_, last_sent_message_ and
last_receiver_id_. So, um, every single private variable of
FakeGCMProfileService :) I think that validates this approach of treating the
CustomFakeGCMDriver as part of the internals of FakeGCMProfileService.

+
   // Indicates whether the service will collect paramters of the calls for
-  // furter verification in tests.
-  bool collect_;
-  // Used to give each registration a unique registration id. Does not decrease
-  // when unregister is called.
-  int registration_count_;
+  // further verification in tests.
+  bool collect_ = false;
+
+  bool is_offline_ = false;

[Peter Beverloo, 2017/02/07 18:11:08]

nit: it's a bit unfortunate that collect_ is documented by the property, but
is_offline_ is documented by the setter. Can we align?

[johnme, 2017/02/08 14:14:36]

Done (documented both at public setter).

+
   std::string last_registered_app_id_;
   std::vector<std::string> last_registered_sender_ids_;
   std::list<GCMClient::Result> unregister_responses_;
   OutgoingMessage last_sent_message_;
   std::string last_receiver_id_;
-  UnregisterCallback unregister_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeGCMProfileService);
 };
 
 }  // namespace gcm
 
 #endif  // CHROME_BROWSER_GCM_FAKE_GCM_PROFILE_SERVICE_H_