[Mac] DialogBrowserTest implementation to invoke Content settings bubble dialogs.

chrome/browser/ui/views/location_bar/location_bar_view.cc

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 3f2dc43dd569f30773e1c7f8130dbb77af3509b2..3a4012a926cccacd374b77d4cb469922af63ef02 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -1097,6 +1097,16 @@ bool LocationBarView::GetBookmarkStarVisibility() {
   return star_view_->visible();
 }
 
+bool LocationBarView::TestContentSettingImagePressed(size_t index) {
+  if (index >= content_setting_views_.size())
+    return false;
+
+  views::View* image_view = content_setting_views_[index];
+  image_view->OnKeyPressed(
+      ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_SPACE, ui::EF_NONE));
+  return true;
+}

[kylix_rd, 2017/02/06 14:12:40]

Doesn't relying on the number and order of the items in content_setting_views_
make this code extremely brittle? What if that order changes? There seems to be
no obvious tie between the index passed in here and the list in
content_setting_bubble_dialog_browsertest.cc. IMO, you've traded fewer changes
to release code for a more brittle test.

+
 ////////////////////////////////////////////////////////////////////////////////
 // LocationBarView, private views::View implementation: