Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2675203006: Add FutureOr to analyzer_cli test async.dart. (Closed)

Created:
3 years, 10 months ago by Leaf
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add timeout for slow test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/analyzer_cli/test/data/package_with_embedder_yaml/lib/async.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Leaf
3 years, 10 months ago (2017-02-07 00:07:44 UTC) #2
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-07 00:47:17 UTC) #3
Bill Hesse
LGTM
3 years, 10 months ago (2017-02-07 00:51:27 UTC) #5
Leaf
3 years, 10 months ago (2017-02-07 01:08:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0c2bf046f19135fee645837c974ab3a7a7d3abd3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698