[string] Don't tail-call into runtime with adaptor frames

src/builtins/builtins-string.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins-regexp.h"
 #include "src/builtins/builtins-utils.h"
 #include "src/builtins/builtins.h"
 #include "src/code-factory.h"
 #include "src/code-stub-assembler.h"
 #include "src/regexp/regexp-utils.h"
@@ skipping 1179 matching lines @@
 
     Node* const dollar_char = Int32Constant('$');
     Node* const index_of_dollar =
         StringIndexOfChar(context, replace, dollar_char, smi_zero);
     GotoUnless(SmiIsNegative(index_of_dollar), &next);
 
     // Searching by traversing a cons string tree and replace with cons of
     // slices works only when the replaced string is a single character, being
     // replaced by a simple string and only pays off for long strings.
     // TODO(jgruber): Reevaluate if this is still beneficial.
-    TailCallRuntime(Runtime::kStringReplaceOneCharWithString, context,
-                    subject_string, search_string, replace);
+    // TODO(jgruber): TailCallRuntime when it correctly handles adapter frames.
+    Return(CallRuntime(Runtime::kStringReplaceOneCharWithString, context,
+                       subject_string, search_string, replace));
 
     Bind(&next);
   }
 
   // TODO(jgruber): Extend StringIndexOfChar to handle two-byte strings and
   // longer substrings - we can handle up to 8 chars (one-byte) / 4 chars
   // (2-byte).
 
   Callable indexof_stub = CodeFactory::StringIndexOf(isolate());
   Node* const match_start_index =
@@ skipping 643 matching lines @@
         CallRuntime(Runtime::kThrowIncompatibleMethodReceiver, context,
                     HeapConstant(factory()->NewStringFromAsciiChecked(
                         "String Iterator.prototype.next", TENURED)),
                     iterator);
     Return(result);  // Never reached.
   }
 }
 
 }  // namespace internal
 }  // namespace v8