Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: pkg/compiler/lib/src/elements/elements.dart

Issue 2675103003: Refactor BackendHelpers to be reusageable with KernelWorldBuilder (Closed)
Patch Set: Updated cf. comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/diagnostics/messages.dart ('k') | pkg/compiler/lib/src/elements/modelx.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/elements/elements.dart
diff --git a/pkg/compiler/lib/src/elements/elements.dart b/pkg/compiler/lib/src/elements/elements.dart
index 15c8cfddef4552207653385f53a157c0149bbad2..883d44ae0831605ddc10046277b1681d1826015d 100644
--- a/pkg/compiler/lib/src/elements/elements.dart
+++ b/pkg/compiler/lib/src/elements/elements.dart
@@ -743,23 +743,23 @@ class Elements {
}
static bool isFixedListConstructorCall(
- Element element, Send node, CommonElements commonElements) {
- return element == commonElements.unnamedListConstructor &&
+ ConstructorEntity element, Send node, CommonElements commonElements) {
+ return commonElements.isUnnamedListConstructor(element) &&
node.isCall &&
!node.arguments.isEmpty &&
node.arguments.tail.isEmpty;
}
static bool isGrowableListConstructorCall(
- Element element, Send node, CommonElements commonElements) {
- return element == commonElements.unnamedListConstructor &&
+ ConstructorEntity element, Send node, CommonElements commonElements) {
+ return commonElements.isUnnamedListConstructor(element) &&
node.isCall &&
node.arguments.isEmpty;
}
static bool isFilledListConstructorCall(
- Element element, Send node, CommonElements commonElements) {
- return element == commonElements.filledListConstructor &&
+ ConstructorEntity element, Send node, CommonElements commonElements) {
+ return commonElements.isFilledListConstructor(element) &&
node.isCall &&
!node.arguments.isEmpty &&
!node.arguments.tail.isEmpty &&
« no previous file with comments | « pkg/compiler/lib/src/diagnostics/messages.dart ('k') | pkg/compiler/lib/src/elements/modelx.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698