Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: components/safe_browsing_db/v4_feature_list.h

Issue 2675063002: Browser tests for using the new SafeBrowsing protocol (v4) (Closed)
Patch Set: Use ANNOTATE_LEAKING_OBJECT_PTR Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing_db/v4_database_unittest.cc ('k') | components/safe_browsing_db/v4_feature_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/v4_feature_list.h
diff --git a/components/safe_browsing_db/v4_feature_list.h b/components/safe_browsing_db/v4_feature_list.h
index f549a9556ab9ec9da6148facf014b629acffffd0..5d7079aee415980951ef1e97961a4f61212dfadd 100644
--- a/components/safe_browsing_db/v4_feature_list.h
+++ b/components/safe_browsing_db/v4_feature_list.h
@@ -11,18 +11,21 @@ namespace safe_browsing {
// through Finch.
namespace V4FeatureList {
-// Is the PVer4 database manager enabled? Should be true if either of those
-// below are true.
-bool IsLocalDatabaseManagerEnabled();
-
-// Is the PVer4 database being checked for resource reputation? If this returns
-// true, use PVer4 database for CheckBrowseUrl, otherwise use PVer3.
-bool IsV4HybridEnabled();
-
-// Is only the PVer4 database being checked for resource reputation? If this
-// returns true, use PVer4 database for all SafeBrowsing operations, and don't
-// update the PVer3 database at all. This is the launch configuration.
-bool IsV4OnlyEnabled();
+enum class V4UsageStatus {
+ // The V4 database manager is not even instantiated i.e. is diabled. All
+ // SafeBrowsing operations use PVer3 code.
+ V4_DISABLED,
+
+ // The V4 database manager is instantiated, and performs background updates,
+ // but all SafeBrowsing verdicts are returned using the PVer3 database.
+ V4_INSTANTIATED,
+
+ // Only the V4 database manager is instantiated, PVer3 database manager is
+ // not. All SafeBrowsing verdicts are returned using PVer4 database.
+ V4_ONLY
+};
+
+V4UsageStatus GetV4UsageStatus();
} // namespace V4FeatureList
« no previous file with comments | « components/safe_browsing_db/v4_database_unittest.cc ('k') | components/safe_browsing_db/v4_feature_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698