Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: components/safe_browsing_db/v4_database_unittest.cc

Issue 2675063002: Browser tests for using the new SafeBrowsing protocol (v4) (Closed)
Patch Set: Use ANNOTATE_LEAKING_OBJECT_PTR Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing_db/v4_database.cc ('k') | components/safe_browsing_db/v4_feature_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/v4_database_unittest.cc
diff --git a/components/safe_browsing_db/v4_database_unittest.cc b/components/safe_browsing_db/v4_database_unittest.cc
index b8e0786aedca30413f7d55130aa2ed9137313179..6b83138a19cafd86536bf5ef227cd9a9b16dece8 100644
--- a/components/safe_browsing_db/v4_database_unittest.cc
+++ b/components/safe_browsing_db/v4_database_unittest.cc
@@ -91,8 +91,8 @@ class V4DatabaseTest : public PlatformTest {
}
void RegisterFactory(bool hash_prefix_matches = true) {
- factory_.reset(new FakeV4StoreFactory(hash_prefix_matches));
- V4Database::RegisterStoreFactoryForTest(factory_.get());
+ V4Database::RegisterStoreFactoryForTest(
+ base::MakeUnique<FakeV4StoreFactory>(hash_prefix_matches));
}
void SetupInfoMapAndExpectedState() {
@@ -206,7 +206,6 @@ class V4DatabaseTest : public PlatformTest {
ListInfos list_infos_;
std::vector<ListIdentifier> expected_identifiers_;
std::vector<base::FilePath> expected_store_paths_;
- std::unique_ptr<FakeV4StoreFactory> factory_;
DatabaseUpdatedCallback callback_db_updated_;
NewDatabaseReadyCallback callback_db_ready_;
StoreStateMap expected_store_state_map_;
« no previous file with comments | « components/safe_browsing_db/v4_database.cc ('k') | components/safe_browsing_db/v4_feature_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698