Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5605)

Unified Diff: chrome/browser/safe_browsing/test_safe_browsing_service.h

Issue 2675063002: Browser tests for using the new SafeBrowsing protocol (v4) (Closed)
Patch Set: Nit: Add comments in tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/test_safe_browsing_service.h
diff --git a/chrome/browser/safe_browsing/test_safe_browsing_service.h b/chrome/browser/safe_browsing/test_safe_browsing_service.h
index facf791b83e2b0acad4529814245db6c0eeeb089..533c7487da12c6412923e31f39a098595689d7bb 100644
--- a/chrome/browser/safe_browsing/test_safe_browsing_service.h
+++ b/chrome/browser/safe_browsing/test_safe_browsing_service.h
@@ -40,7 +40,8 @@ class TestSafeBrowsingUIManager;
// test_sb_factory_.
class TestSafeBrowsingService : public SafeBrowsingService {
public:
- TestSafeBrowsingService();
+ explicit TestSafeBrowsingService(
+ V4FeatureList::V4UsageStatus v4_usage_status);
// SafeBrowsingService overrides
SafeBrowsingProtocolConfig GetProtocolConfig() const override;
V4ProtocolConfig GetV4ProtocolConfig() const override;
@@ -80,7 +81,9 @@ class TestSafeBrowsingService : public SafeBrowsingService {
class TestSafeBrowsingServiceFactory : public SafeBrowsingServiceFactory {
public:
- TestSafeBrowsingServiceFactory();
+ explicit TestSafeBrowsingServiceFactory(
+ V4FeatureList::V4UsageStatus v4_usage_status =
+ V4FeatureList::V4UsageStatus::V4_DISABLED);
~TestSafeBrowsingServiceFactory() override;
// Creates test safe browsing service, and configures test UI manager,
@@ -101,6 +104,7 @@ class TestSafeBrowsingServiceFactory : public SafeBrowsingServiceFactory {
scoped_refptr<TestSafeBrowsingDatabaseManager> test_database_manager_;
scoped_refptr<TestSafeBrowsingUIManager> test_ui_manager_;
SafeBrowsingProtocolConfig* test_protocol_config_;
+ V4FeatureList::V4UsageStatus v4_usage_status_;
DISALLOW_COPY_AND_ASSIGN(TestSafeBrowsingServiceFactory);
};

Powered by Google App Engine
This is Rietveld 408576698