chrome/browser/media/router/mojo/media_router_mojo_impl.h - Issue 2675033002: [Media Router] Add MediaSink subtypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_impl.h

Issue 2675033002: [Media Router] Add MediaSink subtypes (Closed)

Patch Set: resolve code review comments from Derek Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/router/mojo/media_router_mojo_impl.h

diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl.h b/chrome/browser/media/router/mojo/media_router_mojo_impl.h

index 4ee4caf4558c29d43ab398248b7ff40fe207cfc4..5c77cd4dbb20b9528feb9e87ec874ffe5aace5fb 100644

--- a/chrome/browser/media/router/mojo/media_router_mojo_impl.h

+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl.h

@@ -285,7 +285,7 @@ class MediaRouterMojoImpl : public MediaRouterBase,

callback) override;

void OnIssue(const IssueInfo& issue) override;

void OnSinksReceived(const std::string& media_source,

- std::vector<mojom::MediaSinkPtr> sinks,

+ std::vector<std::unique_ptr<MediaSink>> sinks,

const std::vector<std::string>& origins) override;

void OnRoutesUpdated(

std::vector<mojom::MediaRoutePtr> routes,