Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1843)

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

Issue 2675033002: [Media Router] Add MediaSink subtypes (Closed)
Patch Set: resolve code review comments from Derek and Mark Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc b/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
index 20dfac32741c4ed1beef4fe5b074954eabdbc7f0..4c6139a8ff3dc95bb1f7d059b3ef68689be2aece 100644
--- a/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
@@ -697,13 +697,20 @@ TEST_F(MediaRouterMojoImplTest, RegisterAndUnregisterMediaSinksObserver) {
expected_sinks.push_back(
MediaSink(kSinkId2, kSinkName, MediaSink::IconType::CAST));
+ std::vector<MediaSinkInternal> sinks;
+ for (const auto& expected_sink : expected_sinks) {
+ MediaSinkInternal sink_internal;
+ sink_internal.set_sink(expected_sink);
+ sinks.push_back(sink_internal);
+ }
+
base::RunLoop run_loop;
EXPECT_CALL(*sinks_observer, OnSinksReceived(SequenceEquals(expected_sinks)));
EXPECT_CALL(*extra_sinks_observer,
OnSinksReceived(SequenceEquals(expected_sinks)))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
media_router_proxy_->OnSinksReceived(
- media_source.id(), expected_sinks,
+ media_source.id(), sinks,
std::vector<url::Origin>(1, url::Origin(GURL(kOrigin))));
run_loop.Run();

Powered by Google App Engine
This is Rietveld 408576698