[Media Router] Add MediaSink subtypes

chrome/browser/media/router/mojo/media_router_mojo_impl.cc

Index: chrome/browser/media/router/mojo/media_router_mojo_impl.cc
diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
index 82bf5d61afcd190d2b1eff7d8f50206112bf1dd8..93fd8cab79049fece79c32a3b2212457d6b7cc51 100644
--- a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
@@ -174,7 +174,7 @@ void MediaRouterMojoImpl::OnIssue(const IssueInfo& issue) {
 
 void MediaRouterMojoImpl::OnSinksReceived(
     const std::string& media_source,
-    const std::vector<MediaSink>& sinks,
+    const std::vector<MediaSinkInternal>& internal_sinks,
     const std::vector<url::Origin>& origins) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   DVLOG_WITH_INSTANCE(1) << "OnSinksReceived";
@@ -184,6 +184,10 @@ void MediaRouterMojoImpl::OnSinksReceived(
     return;
   }
 
+  std::vector<MediaSink> sinks(internal_sinks.size());

[imcheng, 2017/03/01 22:54:18]

This actually creates a vector with N default-constructed MediaSinks. I think
what you want is:

std::vector<MediaSink> sinks;
sinks.reserve(internal_sinks.size());

[zhaobin, 2017/03/03 23:56:42]

Thanks a lot!

[zhaobin, 2017/03/03 23:56:42]

Done.

+  for (const auto& internal_sink : internal_sinks)
+    sinks.push_back(internal_sink.sink());
+
   auto* sinks_query = it->second.get();
   sinks_query->has_cached_result = true;
   sinks_query->origins = origins;