[Media Router] Add MediaSink subtypes

chrome/browser/media/router/discovery/media_sink_internal.cc

Index: chrome/browser/media/router/discovery/media_sink_internal.cc
diff --git a/chrome/browser/media/router/discovery/media_sink_internal.cc b/chrome/browser/media/router/discovery/media_sink_internal.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a9a5a65d395702935391ea9784e0d277f501bd83
--- /dev/null
+++ b/chrome/browser/media/router/discovery/media_sink_internal.cc
@@ -0,0 +1,73 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/router/discovery/media_sink_internal.h"
+
+#include "base/logging.h"
+#include "base/strings/string_util.h"
+
+namespace media_router {
+
+MediaSinkInternal::MediaSinkInternal(const MediaSink& sink) : sink_(sink) {}
+
+MediaSinkInternal::MediaSinkInternal(const MediaSink& sink,
+                                     const DialSinkExtraData& dial_data)
+    : sink_(sink), dial_data_(dial_data) {}
+
+MediaSinkInternal::MediaSinkInternal(const MediaSink& sink,
+                                     const CastSinkExtraData& cast_data)
+    : sink_(sink), cast_data_(cast_data) {}
+
+MediaSinkInternal::MediaSinkInternal() = default;
+
+MediaSinkInternal::MediaSinkInternal(const MediaSinkInternal& other) = default;
+
+MediaSinkInternal::~MediaSinkInternal() = default;
+
+MediaSinkInternal& MediaSinkInternal::operator=(
+    const MediaSinkInternal& other) = default;
+
+void MediaSinkInternal::set_sink(const MediaSink& sink) {
+  sink_ = sink;
+}
+
+void MediaSinkInternal::set_dial_data(const DialSinkExtraData& dial_data) {
+  DCHECK(dial_data_ || !cast_data_);

[mark a. foltz, 2017/03/01 04:53:19]

Just DCHECK(!cast_data_)?

[zhaobin, 2017/03/01 19:05:56]

Done.

+  dial_data_ = dial_data;
+}
+
+const DialSinkExtraData& MediaSinkInternal::dial_data() const {
+  DCHECK(is_dial_sink());

[mark a. foltz, 2017/03/01 04:53:19]

This is already done by the * operator on base::Optional.

[zhaobin, 2017/03/01 19:05:56]

Done.

+  return *dial_data_;
+}
+
+void MediaSinkInternal::set_cast_data(const CastSinkExtraData& cast_data) {
+  DCHECK(cast_data_ || !dial_data_);

[mark a. foltz, 2017/03/01 04:53:19]

I think this should just be DCHECK(!dial_data_)?  Is it okay to set cast_data
regardless of the previous value?

[zhaobin, 2017/03/01 19:05:56]

Done.

+  cast_data_ = cast_data;
+}
+
+const CastSinkExtraData& MediaSinkInternal::cast_data() const {
+  DCHECK(is_cast_sink());

[mark a. foltz, 2017/03/01 04:53:19]

See above.

[zhaobin, 2017/03/01 19:05:56]

Done.

+  return *cast_data_;
+}
+
+// static
+bool MediaSinkInternal::IsValidSinkId(const std::string& sink_id) {
+  if (sink_id.empty() || !base::IsStringASCII(sink_id)) {
+    DLOG(WARNING) << "Invalid [sink_id]: " << sink_id;
+    return false;
+  }
+
+  return true;
+}
+
+DialSinkExtraData::DialSinkExtraData() = default;
+DialSinkExtraData::DialSinkExtraData(const DialSinkExtraData& other) = default;
+DialSinkExtraData::~DialSinkExtraData() = default;
+
+CastSinkExtraData::CastSinkExtraData() = default;
+CastSinkExtraData::CastSinkExtraData(const CastSinkExtraData& other) = default;
+CastSinkExtraData::~CastSinkExtraData() = default;
+
+}  // namespace media_router